Optimize performance when many new connections arrive #2837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, but why not just increase the backlog? /**
* The number of sockets in the connection backlog. Default 5;
* increase if you expect high connection rates.
* @param backlog The backlog to set.
*/
public void setBacklog(int backlog) {Also, we don't accept code changes without test cases that exercise the new code. |
|
@garyrussell Yes, I also tried to set the backlog, even to 20, and I also set the nioHarvestInterval bigger than default, but it did not work. Everytime AbstractConnectionFactory.processNioSelections execute, there are too many things need to do , and the doAccept is the last one. |
@garyrussell With the current test ConnectionFactoryTests.testObtainConnectionIdsNio, the new code can be converaged, I have run the test. |
|
OK; thanks for the contribution. |
garyrussell
added a commit
to garyrussell/spring-integration
that referenced
this pull request
Mar 28, 2019
See spring-projects#2837 Give priority to accepting new connections over reading data from existing connections. Add a flag to allow users to revert to the previous behavior of giving reads priority. **cherry-pick to 5.1.x**
garyrussell
added a commit
to garyrussell/spring-integration
that referenced
this pull request
Mar 28, 2019
See spring-projects#2837 Give priority to accepting new connections over reading data from existing connections. Add a flag to allow users to revert to the previous behavior of giving reads priority. **cherry-pick to 5.1.x**
garyrussell
added a commit
to garyrussell/spring-integration
that referenced
this pull request
Mar 28, 2019
See spring-projects#2837 Give priority to accepting new connections over reading data from existing connections. Add a flag to allow users to revert to the previous behavior of giving reads priority. **cherry-pick to 5.1.x**
artembilan
pushed a commit
that referenced
this pull request
Mar 28, 2019
See #2837 Give priority to accepting new connections over reading data from existing connections. Add a flag to allow users to revert to the previous behavior of giving reads priority. **cherry-pick to 5.1.x**
artembilan
pushed a commit
that referenced
this pull request
Mar 28, 2019
See #2837 Give priority to accepting new connections over reading data from existing connections. Add a flag to allow users to revert to the previous behavior of giving reads priority. **cherry-pick to 5.1.x** # Conflicts: # spring-integration-ip/src/main/java/org/springframework/integration/ip/tcp/connection/TcpNioServerConnectionFactory.java # src/reference/asciidoc/whats-new.adoc # TcpNioConnectionTests.java
@garyrussell Great job ! And when the 5.1.4 version will be release? |
|
Currently scheduled for next Tuesday (April 2). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When many new connections arrive at once, we should accept as soon as possible. accept connections in a for loop until no new connection is ready