Skip to content

GH-2792: HEnrichSpec: Add hooks for common headers #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2019

Conversation

artembilan
Copy link
Member

Fixes #2792

@artembilan artembilan changed the title GH-2792: HEnrichSpec: Add hooks for common headers [DO NOT MERGE YET] GH-2792: HEnrichSpec: Add hooks for common headers Apr 11, 2019
@artembilan
Copy link
Member Author

If this is OK, I'll add other common header hooks.

It's just too much copy/paste and extra code to support in the future...

@artembilan artembilan changed the title [DO NOT MERGE YET] GH-2792: HEnrichSpec: Add hooks for common headers GH-2792: HEnrichSpec: Add hooks for common headers Apr 12, 2019
@artembilan
Copy link
Member Author

Ready for review.

Thanks

Copy link
Contributor

@garyrussell garyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel your pain 😄

* @since 5.2
*/
public <P> HeaderEnricherSpec expirationDateFunction(Function<Message<P>, Object> expirationDateFunction) {
return priorityFunction(expirationDateFunction, null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy/paste

@garyrussell garyrussell merged commit bf21128 into spring-projects:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add convenient options into the HeaderEnricherSpec for common headers
2 participants