Move SF dependencies to the latest BUILD-SNAPSHOT #2921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid class loader issues it is better to align Spring Data dependencies with SF version we use explicitly. This way we don't have a `ClassLoader` issue when a newly introduced `TransactionManager` might not be visible from the previous versions * Fix code style warnings in the `TransactionSynchronizationFactoryBean` * Use `JavaUtils` in the `TransactionSynchronizationFactoryBean` to decrease code complexity
|
We need to consider to merge this ASAP. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid class loader issues it is better to align Spring Data
dependencies with SF version we use explicitly.
This way we don't have a
ClassLoaderissue when a newly introducedTransactionManagermight not be visible from the previous versionsTransactionSynchronizationFactoryBeanJavaUtilsin theTransactionSynchronizationFactoryBeantodecrease code complexity