Fix TcpNioConnection timedOut set when close. #2938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a good catch! Merging and cherry-picking to all the supported and effected versions. Thank you! |
|
I was going to add a test for this - if we had had a test, we would have caught it before now. |
garyrussell
added a commit
to garyrussell/spring-integration
that referenced
this pull request
May 28, 2019
Close connection in `TcpNioConnection.testInsufficientThreads()`. Before the fix, this would block for 200 seconds, causing the assert on the future completion to fail.
garyrussell
added a commit
to garyrussell/spring-integration
that referenced
this pull request
May 28, 2019
Close connection in `TcpNioConnection.testInsufficientThreads()`. Before the fix, this would block for 200 seconds, causing the assert on the future completion to fail.
garyrussell
added a commit
to garyrussell/spring-integration
that referenced
this pull request
May 28, 2019
Close connection in `TcpNioConnection.testInsufficientThreads()`. Before the fix, this would block for 15 seconds, causing the assert on the future completion to fail.
artembilan
pushed a commit
that referenced
this pull request
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.