INT-3073: Add FluxAggregatorMessageHandler #2954
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just for the sake of PoC. It is really too hard to think reactive way. 😢 I can't yet come up with test, so the main code might be changed. Anyway any feedback welcome! Thanks |
* Fix `FluxAggregatorMessageHandler` for the default `messageForWindowFlux` to rely on the `publish().autoConnect()` to build a target `Flux` for window and also copy headers from the first `Message` in the window. Looks like `switchOnFirst()` doesn't work somehow with windows or I just don't use it properly, although it isn't clear how to continue chain but get the whole `Flux` as a single entry for message payload
|
Added some unit tests for the Still not ready for merge since I may come up with some integration tests with the whole flow processing and also Docs and JavaDocs must have. Thanks anyway. |
* Fix `AbstractMessageSplitter` to cast properly a primitive array
|
Added more tests. |
artembilan
changed the title
|
So, now it's ready for review and merging, unless you would like to see Docs as well in this PR. |
|
Merged as d85d6ee with a bit of javadoc polishing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-3073