GH-2974: Fix race in TcpNetConnection.getPayload() [51x] #2976
+65
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#2974 There is a race in that we could get a `SocketException` in `inputStream`. Since this is between payloads, it needs to be thrown as a `SoftEndOfStreamException`. Also fix unnecessary `this.` in `MessageHistoryConfigurer.java`. **cherry-pick to 5.0.x, 4.3.x**
artembilan
reviewed
Jun 26, 2019
| Socket socket = SocketFactory.getDefault().createSocket("localhost", port.get()); | ||
| TcpNetConnection connection = new TcpNetConnection(socket, false, false, publisher, "socketClosedNextRead"); | ||
| socket.close(); | ||
| assertThatThrownBy(() -> connection.getPayload()) |
There was a problem hiding this comment.
This is not going to back-port smoothly: there is no AssertJ in the requested versions.
I'll figure during cherry-picking...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2974
There is a race in that we could get a
SocketExceptionininputStream.Since this is between payloads, it needs to be thrown as a
SoftEndOfStreamException.Also fix unnecessary
this.inMessageHistoryConfigurer.java.cherry-pick to 5.0.x, 4.3.x