GH-2993: Catch and log unsupported XML attributes #2994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#2993 Not all XML components support all the configuration properties. For example Saxon HE doesn't support `XMLConstants.ACCESS_EXTERNAL_DTD` and end up with an exception like: `IllegalArgumentException: Unknown configuration property http://javax.xml.XMLConstants/property/accessExternalDTD` * Copy `TransformerFactoryUtils` from the latest Spring WS, where all the attributes are wrapped into `try..catch` and warn log. And use this new class everywhere instead of non-patched in Spring WS * Upgrade to the latest Spring WS 2.4.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2993
Not all XML components support all the configuration properties.
For example Saxon HE doesn't support
XMLConstants.ACCESS_EXTERNAL_DTDand end up with an exception like:
IllegalArgumentException: Unknown configuration property http://javax.xml.XMLConstants/property/accessExternalDTDTransformerFactoryUtilsfrom the latest Spring WS, whereall the attributes are wrapped into
try..catchand warn log.And use this new class everywhere instead of non-patched in Spring WS