Improve ImapIdleChannelAdapter #3045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We should not destroy a `TaskExecutor` in the `stop()`, especially when we are going to restart eventually. Move that logic into `destroy()` * we should not destroy `MailReceiver` in the `stop()`; we don't reinstate it in the `start()`. Move the logic into `destroy()` * Wrap `ReceivingTask` and `IdleTask` into `isRunning()` condition to avoid task executions when we are in stopped state * Remove `ImapMailReceiverTests.testExecShutdown()` since it is not relevant any more and doesn't reflect `mail` module requirements
|
Also it looks like |
garyrussell
suggested changes
Aug 28, 2019
| @@ -156,29 +156,22 @@ public void setApplicationEventPublisher(ApplicationEventPublisher applicationEv | |||
| protected void doStart() { | |||
| TaskScheduler scheduler = getTaskScheduler(); | |||
| Assert.notNull(scheduler, "'taskScheduler' must not be null"); | |||
| if (this.sendingTaskExecutor == null) { | |||
| this.sendingTaskExecutor = Executors.newFixedThreadPool(1); | |||
| } | |||
| this.receivingTask = scheduler.schedule(new ReceivingTask(), this.receivingTaskTrigger); | |||
| } | |||
|
|
|||
| @Override | |||
| // guarded by super#lifecycleLock | |||
| protected void doStop() { | |||
| this.receivingTask.cancel(true); | |||
There was a problem hiding this comment.
It looks like we still need to cancel the pingTask in the receiver. Add Lifecycle ?
What about closing the folder?
* Also close folder for each `stop()`, as well as in the `destroy()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskExecutorin thestop(), especiallywhen we are going to restart eventually.
Move that logic into
destroy()MailReceiverin thestop(); we don'treinstate it in the
start().Move the logic into
destroy()ReceivingTaskandIdleTaskintoisRunning()condition toavoid task executions when we are in stopped state
ImapMailReceiverTests.testExecShutdown()since it is notrelevant any more and doesn't reflect
mailmodule requirements