GH-3052: Fix custom converters for lambdas #3053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3052 Starting with version `5.1`, a `LambdaMessageProcessor` is based on the `MessageConverter` instead of plain `ConversionService`. (A `ConfigurableCompositeMessageConverter` is used from the application context.) However a type conversion based on the `@IntegrationConverter` is lost in the `GenericMessageConverter` because it doesn't use an `integrationConversionService` from the application context * Change `ConfigurableCompositeMessageConverter` to configure a `GenericMessageConverter` with an `integrationConversionService` if any * Fix `MessagingMethodInvokerHelper` to populate a `BeanFactory` into its internal `ConfigurableCompositeMessageConverter` * Ensure in the `LambdaMessageProcessorTests` that `@IntegrationConverter` is applied for ``LambdaMessageProcessor` as well **Cherry-pick to 5.1.x**
|
Cherry-pick is not clean - please backport. |
|
Back-ported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3052
Starting with version
5.1, aLambdaMessageProcessoris based on theMessageConverterinstead of plainConversionService.(A
ConfigurableCompositeMessageConverteris used from the applicationcontext.)
However a type conversion based on the
@IntegrationConverteris lostin the
GenericMessageConverterbecause it doesn't use anintegrationConversionServicefrom the application contextConfigurableCompositeMessageConverterto configure aGenericMessageConverterwith anintegrationConversionServiceif any
MessagingMethodInvokerHelperto populate aBeanFactoryintoits internal
ConfigurableCompositeMessageConverterLambdaMessageProcessorTeststhat@IntegrationConverteris applied for ``LambdaMessageProcessor` as wellCherry-pick to 5.1.x