Skip to content

GH-3083: Support @Header with dotted literals #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

garyrussell
Copy link
Contributor

@garyrussell garyrussell commented Oct 16, 2019

Fixes #3083

@Header("foo.bar") means extract property bar from header foo.

Support @Header("'foo.bar'"), meaning get the value of header foo.bar.

cherry-pick to 5.1.x, 4.3.x

Fixes spring-projects#3083

`@Header("foo.bar")` means extract property `bar` from header `foo`.

Support `@Header("'foo.bar'")`, meaning get the value of header `foo.bar`.

**cherry-pick to 5.1.x, 4.3.x**
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we haven't had this SpEL support in @Header from the beginning at all...
It is too complicated and can be achieved with much cleaner code before or after header extraction.

But you fixed it - LGTM!

@artembilan artembilan merged commit 87af95e into spring-projects:master Oct 16, 2019
@artembilan
Copy link
Member

... and cherry-picked to 5.1.x and 4.3.x after fixing conflicts.

@gabrielbauman
Copy link

Thank you for this. We hit it pretty hard and it took us awhile to realize SpEL was going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@Header("'foo.bar'") looks for a header ''foo' with property bar'
3 participants