INT-3494: Resolve dir for writing as a Resource #3109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://jira.spring.io/browse/INT-3494 The expression for local directory can be resolved into a `Resource` or resource location. * Fix `ExpressionUtils.expressionToFile()` to support `Resource` and also use `ResourceUtils.getFile(path)` when expression result is a string * Modify tests to ensure that resource is resolved properly * Upgrade affected tests to JUnit 5 * Mention an new functionality in docs
garyrussell
suggested changes
Nov 14, 2019
| @@ -168,29 +172,49 @@ private static EvaluationContext createEvaluationContext(@Nullable ConversionSer | |||
| public static File expressionToFile(Expression expression, EvaluationContext evaluationContext, | |||
| @Nullable Message<?> message, String name) { | |||
There was a problem hiding this comment.
We should take this opportunity to improve the javadocs for the name parameter.
@param name the name of the result of the evaluation.
@param name the name of the property we are evaluating an expression for ?
Yeah... That's my flaw: I can't stay away if I see that code should be refactored 😄 Will work on that habit for future tasks! |
* Finish the sentence in the `file.adoc`
garyrussell
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-3494
The expression for local directory can be resolved into a
Resourceor resource location.
ExpressionUtils.expressionToFile()to supportResourceandalso use
ResourceUtils.getFile(path)when expression result is a string