Introduce RSocketInteractionModel #3110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deprecate `RSocketOutboundGateway.Command` in favor of newly introduced top level `RSocketInteractionModel` * Deprecate setter, DSL and XML configurations for the deprecated `RSocketOutboundGateway.Command` in favor of newly introduced configurators for the mentioned `RSocketInteractionModel` * Add `IntegrationRSocketEndpoint.getInteractionModels()` contract for inbound endpoints. This way we can restrict mapped endpoints to the particular interaction model(s) * Add DSL and XML configuration for inbound interaction model option * Document changes
* Fix consistency for `RetrieveSpec` in the `RSocketOutboundGateway` and `rsocket.adoc`
artembilan
force-pushed
the
RSocket_InteractionModel
branch
from
ab5a5b5 to
28e4c22
Compare
|
Rebased to @garyrussell , any chances to have this reviewed and merged for upcoming release this Wednesday? Thanks |
garyrussell
suggested changes
Dec 2, 2019
| } | ||
|
|
||
| /** | ||
| * Configure a SpEL expression to evaluate a {@link RSocketInteractionModel} |
There was a problem hiding this comment.
s/a/an/
for the RSocket request...
(all occurrences)
garyrussell
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSocketOutboundGateway.Commandin favor of newly introducedtop level
RSocketInteractionModelRSocketOutboundGateway.Commandin favor of newly introduced configuratorsfor the mentioned
RSocketInteractionModelIntegrationRSocketEndpoint.getInteractionModels()contract forinbound endpoints.
This way we can restrict mapped endpoints to the particular interaction
model(s)