AMQP: Multiple Sends within an OB Channel Adapter #3170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for: spring-attic/spring-cloud-stream-binder-rabbit#209 When `multiSend` is true and multiple messages are sent as the payload of a message, each message is sent within the `invoke()` method of the `RabbitTemplate`.
artembilan
requested changes
Feb 6, 2020
| */ | ||
| public class AmqpOutboundChannelAdapterSpec extends AmqpOutboundEndpointSpec<AmqpOutboundChannelAdapterSpec> { | ||
|
|
||
| AmqpOutboundChannelAdapterSpec(AmqpTemplate amqpTemplate) { |
There was a problem hiding this comment.
Gary, can you make all the ctors and final props in these AMQP specs as protected for possible extension?
So, I won't include them into my extensions PR #3167 to avoid conflicts between our two fixes.
Thanks
artembilan
approved these changes
Feb 6, 2020
| * @return the spec. | ||
| * @since 5.3 | ||
| */ | ||
| public S confirmTimeout(long timeout) { |
There was a problem hiding this comment.
Right, this is one of those I'd like to cover with DSL extensions and all those protected ctors 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for: spring-attic/spring-cloud-stream-binder-rabbit#209
When
multiSendis true and multiple messages are sent as the payloadof a message, each message is sent within the
invoke()method of theRabbitTemplate.