GH-3168: Fix FtpSession warning on logout#3174
Merged
garyrussell merged 1 commit intospring-projects:masterfrom Feb 11, 2020
Merged
GH-3168: Fix FtpSession warning on logout#3174garyrussell merged 1 commit intospring-projects:masterfrom
garyrussell merged 1 commit intospring-projects:masterfrom
Conversation
Fixes spring-projects#3168 * Call `this.client.noop()` instead of `this.client.isConnected()` to really check that client has a live connection with the server before calling a `this.client.logout()` * Wrap `this.client.logout()` into a `try..catch` to be sure that we wil call a `this.client.disconnect()` even if `logout()` fails for some reason. * Change `WARN` logs about `Session.close()` into a `DEBUG` level - when we have a problem with closing session because of server disconnect reason we have no any control to do with a situation **Cherry-pick to 5.2.x**
Member
Author
|
FYI if you wish to review. Thanks |
Contributor
|
LGTM; will merge in the morning unless we hear otherwise from @jonforums |
|
LGTM, thanks! |
Contributor
|
Cherry-picked as 23b1a9f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3168
this.client.noop()instead ofthis.client.isConnected()to reallycheck that client has a live connection with the server before calling a
this.client.logout()this.client.logout()into atry..catchto be sure that we wil call athis.client.disconnect()even iflogout()fails for some reason.WARNlogs aboutSession.close()into aDEBUGlevel -when we have a problem with closing session because of server disconnect reason
we have no any control to do with a situation
Cherry-pick to 5.2.x