Skip to content

Timeout added to WebFluxMessageHandlerSpec.java & WebFluxRequestExecutingMessageHandler.java #3187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

sirimamilla
Copy link
Contributor

Timeout added to WebFluxMessageHandlerSpec.java & WebFluxRequestExecutingMessageHandler.java #3183

I have not added the timeout to XML and Java Annotation.

Please guide me on the classes to change for the XML and Annotation changes.

@artembilan
Copy link
Member

@sirimamilla ,

thank you for your effort!

But first of all we have not agreed yet in the issue about the feature implementation.
Secondly, please, take a look here: https://github.com/spring-projects/spring-integration/blob/master/CONTRIBUTING.adoc

It really would be better to contribute from the top-level branch, not master as you have done it again.

@garyrussell , what is your opinion about suggested feature? See #3183
Thanks

@sirimamilla
Copy link
Contributor Author

Hi @artembilan ,

I am closing this pull request and created a new pull request from feature branch. I worked in local on feature branch but pushed wrongly to master branch and raised PR from there.

@sirimamilla
Copy link
Contributor Author

#3188 new pull request for this issue.

@artembilan artembilan closed this Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants