GH-3199: FailoverClientCF - Fail Back Option #3200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: spring-projects#3199 Previously, the FCCF did not cache a shared connection; if server 1 is down and server 2 is up, this caused an attempt to connect to server 1 every time we got the connection. Add 2 options: `refreshSharedInterval` and `closeOnRefresh`, defaulting to 0 and false respectively, to maintain the same behavior as before the options existed. Disallow caching of the single shared connection if the delegate factories are `CachingClientConnectionFactory` instances. **cherry-pick to 5.2.x** I will backport to 5.1.x, 4.3.x after review/merge.
artembilan
requested changes
Feb 28, 2020
src/reference/asciidoc/ip.adoc
Outdated
|
|
||
| Set `refreshSharedInterval` to only attempt to reconnect with the first factory after that time has expired; set it to `Long.MAX_VALUE` if you only want to fail back to the first factory when the current connection fails. | ||
|
|
||
| Set `closeOnRefresh` to close thee "old" connection after a refresh actually creates a new connection. |
There was a problem hiding this comment.
Suggested change
| Set `closeOnRefresh` to close thee "old" connection after a refresh actually creates a new connection. | |
| Set `closeOnRefresh` to close the "old" connection after a refresh actually creates a new connection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3199
Previously, the FCCF did not cache a shared connection; if server 1 is down
and server 2 is up, this caused an attempt to connect to server 1 every time
we got the connection.
Add 2 options:
refreshSharedIntervalandcloseOnRefresh, defaulting to0 and false respectively, to maintain the same behavior as before the options
existed.
Disallow caching of the single shared connection if the delegate factories are
CachingClientConnectionFactoryinstances.cherry-pick to 5.2.x
I will backport to 5.1.x, 4.3.x after review/merge.