Document Kotlin DSL by artembilan · Pull Request #3210 · spring-projects/spring-integration

artembilan · 2020-03-05T21:41:03Z

Remove unused imports in FunctionsTests.kt

garyrussell · 2020-03-10T19:55:12Z

src/reference/asciidoc/kotlin-dsl.adoc

+
+The Kotlin DSL is a wrapper and extension to <<./dsl.adoc#java-dsl,Java DSL>> and aimed to make Spring Integration development on Kotlin as smooth and straightforward as is it possible with interoperability with existing Java API and Kotlin language-specific structures.
+
+All you need to get started is just an import for `org.springframework.integration.dsl.integrationFlow` - an overloaded global function for Kotlin DSL.


Suggested change

All you need to get started is just an import for `org.springframework.integration.dsl.integrationFlow` - an overloaded global function for Kotlin DSL.

All you need to get started is just an import for `org.springframework.integration.dsl.kotlin.integrationFlow` - an overloaded global function for Kotlin DSL.

garyrussell · 2020-03-10T19:56:51Z

src/reference/asciidoc/kotlin-dsl.adoc

+[[kotlin-dsl]]
+== Kotlin DSL
+
+The Kotlin DSL is a wrapper and extension to <<./dsl.adoc#java-dsl,Java DSL>> and aimed to make Spring Integration development on Kotlin as smooth and straightforward as is it possible with interoperability with existing Java API and Kotlin language-specific structures.


Suggested change

The Kotlin DSL is a wrapper and extension to <<./dsl.adoc#java-dsl,Java DSL>> and aimed to make Spring Integration development on Kotlin as smooth and straightforward as is it possible with interoperability with existing Java API and Kotlin language-specific structures.

The Kotlin DSL is a wrapper and extension to <<./dsl.adoc#java-dsl,Java DSL>> and aimed to make Spring Integration development on Kotlin as smooth and straightforward as possible with interoperability with the existing Java API and Kotlin language-specific structures.

``` @

garyrussell · 2020-03-10T19:59:35Z

src/reference/asciidoc/kotlin-dsl.adoc

+See more overloaded `integrationFlow()` variants below.
+
+Many other scenarios require an `IntegrationFlow` to be started from source of data (e.g. `JdbcPollingChannelAdapter`, `JmsInboundGateway` or just an existing `MessageChannel`).
+For this purpose Spring Integration Java DSL provides an `IntegrationFlows` factory with its bunch of overloaded `from()` methods.


Suggested change

For this purpose Spring Integration Java DSL provides an `IntegrationFlows` factory with its bunch of overloaded `from()` methods.

For this purpose, the Spring Integration Java DSL provides an `IntegrationFlows` factory with its large number of overloaded `from()` methods.

garyrussell · 2020-03-10T20:00:20Z

src/reference/asciidoc/kotlin-dsl.adoc

+====
+
+But unfortunately not all `from()` methods are compatible with Kotlin structures.
+To fix a gap, this project provides a Kotlin DSL around an `IntegrationFlows` factory.


Suggested change

To fix a gap, this project provides a Kotlin DSL around an `IntegrationFlows` factory.

To fix the gap, this project provides a Kotlin DSL around an `IntegrationFlows` factory.

garyrussell · 2020-03-10T20:01:41Z

src/reference/asciidoc/kotlin-dsl.adoc

+
+But unfortunately not all `from()` methods are compatible with Kotlin structures.
+To fix a gap, this project provides a Kotlin DSL around an `IntegrationFlows` factory.
+It is done as a set of overloaded `integrationFlow()` functions.


Suggested change

It is done as a set of overloaded `integrationFlow()` functions.

It is implemented as a set of overloaded `integrationFlow()` functions.

garyrussell · 2020-03-10T20:03:24Z

src/reference/asciidoc/kotlin-dsl.adoc

+But unfortunately not all `from()` methods are compatible with Kotlin structures.
+To fix a gap, this project provides a Kotlin DSL around an `IntegrationFlows` factory.
+It is done as a set of overloaded `integrationFlow()` functions.
+With a consumer for a `KotlinIntegrationFlowDefinition` to declare the rest of the flow as an `IntegrationFlow` lambda to reuse the mentioned above experience and also avoid `get()` call in the end.


Suggested change

With a consumer for a `KotlinIntegrationFlowDefinition` to declare the rest of the flow as an `IntegrationFlow` lambda to reuse the mentioned above experience and also avoid `get()` call in the end.

With a consumer for a `KotlinIntegrationFlowDefinition`, to declare the rest of the flow as an `IntegrationFlow` lambda to reuse the mentioned above experience; unlike the Java DSL, it also avoids the need for a `get()` call at the end of the flow.

garyrussell · 2020-03-10T20:04:19Z

src/reference/asciidoc/kotlin-dsl.adoc

+----
+====
+
+In addition Kotlin extensions are provided for Java DSL API which needs some refinement for Kotlin structures.


Suggested change

In addition Kotlin extensions are provided for Java DSL API which needs some refinement for Kotlin structures.

In addition, Kotlin extensions are provided for the Java DSL API which needs some refinement for Kotlin structures.

* Remove unused imports in `FunctionsTests.kt`

artembilan modified the milestones: 5.3.x, 5.3.M3 Mar 5, 2020

garyrussell suggested changes Mar 10, 2020

View reviewed changes

artembilan added 2 commits March 10, 2020 16:39

Document Kotlin DSL

e7786f6

* Remove unused imports in `FunctionsTests.kt`

* Fix typos in Docs

a4d070e

artembilan force-pushed the kotlin_dsl_docs branch from f0759ef to a4d070e Compare March 10, 2020 20:43

artembilan requested a review from garyrussell March 10, 2020 20:43

garyrussell approved these changes Mar 10, 2020

View reviewed changes

garyrussell merged commit 36f96ec into spring-projects:master Mar 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Document Kotlin DSL#3210

Document Kotlin DSL#3210
garyrussell merged 2 commits intospring-projects:masterfrom
artembilan:kotlin_dsl_docs

artembilan commented Mar 5, 2020

Uh oh!

garyrussell Mar 10, 2020

Uh oh!

garyrussell Mar 10, 2020

Uh oh!

garyrussell Mar 10, 2020

Uh oh!

garyrussell Mar 10, 2020

Uh oh!

garyrussell Mar 10, 2020

Uh oh!

garyrussell Mar 10, 2020

Uh oh!

garyrussell Mar 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		The Kotlin DSL is a wrapper and extension to <<./dsl.adoc#java-dsl,Java DSL>> and aimed to make Spring Integration development on Kotlin as smooth and straightforward as is it possible with interoperability with existing Java API and Kotlin language-specific structures.

		All you need to get started is just an import for `org.springframework.integration.dsl.integrationFlow` - an overloaded global function for Kotlin DSL.

	The Kotlin DSL is a wrapper and extension to <<./dsl.adoc#java-dsl,Java DSL>> and aimed to make Spring Integration development on Kotlin as smooth and straightforward as is it possible with interoperability with existing Java API and Kotlin language-specific structures.
	The Kotlin DSL is a wrapper and extension to <<./dsl.adoc#java-dsl,Java DSL>> and aimed to make Spring Integration development on Kotlin as smooth and straightforward as possible with interoperability with the existing Java API and Kotlin language-specific structures.
	``` @

	For this purpose Spring Integration Java DSL provides an `IntegrationFlows` factory with its bunch of overloaded `from()` methods.
	For this purpose, the Spring Integration Java DSL provides an `IntegrationFlows` factory with its large number of overloaded `from()` methods.

	To fix a gap, this project provides a Kotlin DSL around an `IntegrationFlows` factory.
	To fix the gap, this project provides a Kotlin DSL around an `IntegrationFlows` factory.

	It is done as a set of overloaded `integrationFlow()` functions.
	It is implemented as a set of overloaded `integrationFlow()` functions.

	With a consumer for a `KotlinIntegrationFlowDefinition` to declare the rest of the flow as an `IntegrationFlow` lambda to reuse the mentioned above experience and also avoid `get()` call in the end.
	With a consumer for a `KotlinIntegrationFlowDefinition`, to declare the rest of the flow as an `IntegrationFlow` lambda to reuse the mentioned above experience; unlike the Java DSL, it also avoids the need for a `get()` call at the end of the flow.

	In addition Kotlin extensions are provided for Java DSL API which needs some refinement for Kotlin structures.
	In addition, Kotlin extensions are provided for the Java DSL API which needs some refinement for Kotlin structures.

Conversation

artembilan commented Mar 5, 2020

Uh oh!

garyrussell Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

garyrussell Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

garyrussell Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

garyrussell Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

garyrussell Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

garyrussell Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

garyrussell Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants