Skip to content

GH-3509: Register TcpSenders on wrapped connection#3510

Closed
gigermocas wants to merge 1 commit into
spring-projects:masterfrom
gigermocas:master
Closed

GH-3509: Register TcpSenders on wrapped connection#3510
gigermocas wants to merge 1 commit into
spring-projects:masterfrom
gigermocas:master

Conversation

@gigermocas
Copy link
Copy Markdown
Contributor

@gigermocas gigermocas commented Mar 12, 2021

Fixes #3509

Dead connections are not being removed on TcpSender when using a TcpConnectionInterceptor
May cause a memory leak

@pivotal-issuemaster
Copy link
Copy Markdown

pivotal-issuemaster commented Mar 12, 2021

@gigermocas Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link
Copy Markdown

pivotal-issuemaster commented Mar 12, 2021

@gigermocas Thank you for signing the Contributor License Agreement!

@gigermocas
spring-projectsGH-3509: Register TcpSenders on wrapped connection
1c9d550 
Fixes spring-projects#3509

Dead connections are not being removed on `TcpSender` when using a `TcpConnectionInterceptor`
May cause a memory leak
@gigermocas
Copy link
Copy Markdown
Contributor Author

gigermocas commented Mar 12, 2021

I messed up, pull request should be based on my own issue branch, instead of master, is this fixable?

@artembilan
Copy link
Copy Markdown
Member

artembilan commented Mar 12, 2021

No, that's OK. We still can review and merge it.
You will just need to do git reset --hard upsteam/master for your local copy after we merge this PR.
Will review it shortly.
Thanks

artembilan
artembilan approved these changes Mar 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far!
Pulling locally for final review and possible clean up, e.g. add you name to the @author list of all the affected classes.

@artembilan
Copy link
Copy Markdown
Member

artembilan commented Mar 12, 2021

Merged and cherry-picked to 5.4.x as 78a0ae8 after some clean up.

Thank you for contribution; looking forward for more!

@artembilan artembilan closed this Mar 12, 2021
@gigermocas gigermocas mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artembilan artembilan artembilan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Memory leak through TcpSendingMessageHandler's connections map

3 participants

@gigermocas @pivotal-issuemaster @artembilan