INT-2592 Fix Memory Leak in SimpleMessageStore #463
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locks used to control access to a group of messages were never removed from the collection. Converted to use LockRegistry, which (by default) uses a pool of reentrant locks, using the hashcode of the group id as an index into the pool. Given that the pool is fixed, there is nothing to remove, thus avoiding the memory leak. When used within AbstractCorrelatingMessageHandler, any custom LockRegistry supplied will also be used by the message store, thus allowing the user to increase or decrease the size of the lock pool. The registry can not be changed once the SimpleMessageGroup has been used. Also, the ACMH had some protection to avoid setting the LockRegistry more than once, but this did not protect against the default lock registry being replaced after it had been used. Added additional protection to avoid this condition by setting lockRegistrySet to true in onInit().
PR Comments. Now, if a custom lock registry is required, it must be supplied to both the ACMH and SMS.
olegz
added a commit
to olegz/spring-integration
that referenced
this pull request
Jun 1, 2012
* INT-2592: INT-2592 Fix Memory Leak in SimpleMessageStore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.springsource.org/browse/INT-2592
Note: May be easier to review on the command line
with 'git log -p -b' because locking code changed
the indentation of the business code.
Locks used to control access to a group of messages were
never removed from the collection.
Converted to use LockRegistry, which (by default) uses
a pool of reentrant locks, using the hashcode of the group id
as an index into the pool.
Given that the pool is fixed, there is nothing to remove, thus
avoiding the memory leak.
When used within AbstractCorrelatingMessageHandler, any
custom LockRegistry supplied will also be used by the message
store, thus allowing the user to increase or decrease the
size of the lock pool. The registry can not be changed
once the SimpleMessageGroup has been used.
Also, the ACMH had some protection to avoid setting the
LockRegistry more than once, but this did not protect
against the default lock registry being replaced after
it had been used. Added additional protection to avoid
this condition by setting lockRegistrySet to true in
onInit().