-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Introduce PartitionedChannel
#8617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
garyrussell
merged 6 commits into
spring-projects:main
from
artembilan:PartitionedChannel
May 10, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
de82766
Introduce `PartitionedChannel`
artembilan fd961c9
* Fix language in Javadocs
artembilan 2b6d243
* Fix language in Javadocs
artembilan 584f00d
* Populate partitions from `PartitionedDispatcher` ctor
artembilan cc3a6c6
* Clear `executors` in `populatedPartitions()`
artembilan 7c6c56b
* Bring back `synchronized populatedPartitions()` and use it in the `…
artembilan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
148 changes: 148 additions & 0 deletions
148
...ration-core/src/main/java/org/springframework/integration/channel/PartitionedChannel.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,148 @@ | ||
/* | ||
* Copyright 2023 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.integration.channel; | ||
|
||
import java.util.concurrent.ThreadFactory; | ||
import java.util.function.Function; | ||
|
||
import org.springframework.integration.IntegrationMessageHeaderAccessor; | ||
import org.springframework.integration.dispatcher.LoadBalancingStrategy; | ||
import org.springframework.integration.dispatcher.PartitionedDispatcher; | ||
import org.springframework.lang.Nullable; | ||
import org.springframework.messaging.Message; | ||
import org.springframework.scheduling.concurrent.CustomizableThreadFactory; | ||
import org.springframework.util.Assert; | ||
|
||
/** | ||
* An {@link AbstractExecutorChannel} implementation for partitioned message dispatching. | ||
* Requires a number of partitions where each of them is backed by a dedicated thread. | ||
* The {@code partitionKeyFunction} is used to determine to which partition the message | ||
* has to be dispatched. | ||
* By default, the {@link IntegrationMessageHeaderAccessor#CORRELATION_ID} message header is used | ||
* for partition key. | ||
* <p> | ||
* The actual dispatching and threading logic is implemented in the {@link PartitionedDispatcher}. | ||
* <p> | ||
* The default {@link ThreadFactory} is based on the bean name of this channel plus {@code -partition-thread-}. | ||
* Thus, every thread name will reflect a partition it belongs to. | ||
* <p> | ||
* The rest of the logic is similar to the {@link ExecutorChannel}, which includes: | ||
* - load balancing for subscribers; | ||
* - fail-over and error handling; | ||
* - channel operations intercepting. | ||
* | ||
* @author Artem Bilan | ||
* | ||
* @since 6.1 | ||
* | ||
* @see PartitionedDispatcher | ||
*/ | ||
public class PartitionedChannel extends AbstractExecutorChannel { | ||
|
||
@Nullable | ||
private ThreadFactory threadFactory; | ||
|
||
/** | ||
* Instantiate based on a provided number of partitions and function resolving a partition key from | ||
* the {@link IntegrationMessageHeaderAccessor#CORRELATION_ID} message header. | ||
* @param partitionCount the number of partitions in this channel. | ||
* sent to this channel. | ||
*/ | ||
public PartitionedChannel(int partitionCount) { | ||
this(partitionCount, (message) -> message.getHeaders().get(IntegrationMessageHeaderAccessor.CORRELATION_ID)); | ||
} | ||
|
||
/** | ||
* Instantiate based on a provided number of partitions and function for partition key against | ||
* the message. | ||
* @param partitionCount the number of partitions in this channel. | ||
* @param partitionKeyFunction the function to resolve a partition key against the message | ||
* sent to this channel. | ||
*/ | ||
public PartitionedChannel(int partitionCount, Function<Message<?>, Object> partitionKeyFunction) { | ||
super(null); | ||
this.dispatcher = new PartitionedDispatcher(partitionCount, partitionKeyFunction); | ||
} | ||
|
||
/** | ||
* Set a {@link ThreadFactory} for executors per partitions. | ||
* Propagated down to the {@link PartitionedDispatcher}. | ||
* Defaults to the {@link CustomizableThreadFactory} based on the bean name | ||
* of this channel plus {@code -partition-thread-}. | ||
* @param threadFactory the {@link ThreadFactory} to use. | ||
*/ | ||
public void setThreadFactory(ThreadFactory threadFactory) { | ||
artembilan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Assert.notNull(threadFactory, "'threadFactory' must not be null"); | ||
this.threadFactory = threadFactory; | ||
} | ||
|
||
/** | ||
* Specify whether the channel's dispatcher should have failover enabled. | ||
* By default, it will. Set this value to 'false' to disable it. | ||
* @param failover The failover boolean. | ||
*/ | ||
public void setFailover(boolean failover) { | ||
getDispatcher().setFailover(failover); | ||
} | ||
|
||
/** | ||
* Provide a {@link LoadBalancingStrategy} for the {@link PartitionedDispatcher}. | ||
* @param loadBalancingStrategy The load balancing strategy implementation. | ||
*/ | ||
public void setLoadBalancingStrategy(@Nullable LoadBalancingStrategy loadBalancingStrategy) { | ||
artembilan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
getDispatcher().setLoadBalancingStrategy(loadBalancingStrategy); | ||
} | ||
|
||
@Override | ||
protected PartitionedDispatcher getDispatcher() { | ||
return (PartitionedDispatcher) this.dispatcher; | ||
} | ||
|
||
@Override | ||
protected void onInit() { | ||
super.onInit(); | ||
|
||
if (this.threadFactory == null) { | ||
this.threadFactory = new CustomizableThreadFactory(getComponentName() + "-partition-thread-"); | ||
} | ||
PartitionedDispatcher partitionedDispatcher = getDispatcher(); | ||
partitionedDispatcher.setThreadFactory(this.threadFactory); | ||
|
||
if (this.maxSubscribers == null) { | ||
partitionedDispatcher.setMaxSubscribers(getIntegrationProperties().getChannelsMaxUnicastSubscribers()); | ||
} | ||
|
||
partitionedDispatcher.setErrorHandler(ChannelUtils.getErrorHandler(getBeanFactory())); | ||
|
||
partitionedDispatcher.setMessageHandlingTaskDecorator(task -> { | ||
if (this.executorInterceptorsSize > 0) { | ||
return new MessageHandlingTask(task); | ||
} | ||
else { | ||
return task; | ||
} | ||
}); | ||
|
||
} | ||
|
||
@Override | ||
public void destroy() { | ||
super.destroy(); | ||
getDispatcher().shutdown(); | ||
} | ||
|
||
} |
191 changes: 191 additions & 0 deletions
191
...-core/src/main/java/org/springframework/integration/dispatcher/PartitionedDispatcher.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,191 @@ | ||
/* | ||
* Copyright 2023 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.integration.dispatcher; | ||
|
||
import java.util.ArrayList; | ||
import java.util.HashMap; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.Set; | ||
import java.util.concurrent.Executor; | ||
import java.util.concurrent.ExecutorService; | ||
import java.util.concurrent.Executors; | ||
import java.util.concurrent.ThreadFactory; | ||
import java.util.function.Function; | ||
|
||
import org.springframework.integration.util.ErrorHandlingTaskExecutor; | ||
import org.springframework.lang.Nullable; | ||
import org.springframework.messaging.Message; | ||
import org.springframework.messaging.MessageHandler; | ||
import org.springframework.scheduling.concurrent.CustomizableThreadFactory; | ||
import org.springframework.util.Assert; | ||
import org.springframework.util.ErrorHandler; | ||
|
||
/** | ||
* An {@link AbstractDispatcher} implementation for distributing messages to | ||
* dedicated threads according to the key determined by the provided function against | ||
* the message to dispatch. | ||
* <p> | ||
* Every partition, created by this class, is a {@link UnicastingDispatcher} | ||
* delegate based on a single thread {@link Executor}. | ||
* <p> | ||
* The number of partitions should be a reasonable value for the application environment | ||
* since every partition is based on a dedicated thread for message processing. | ||
* <p> | ||
* The rest of the logic is similar to {@link UnicastingDispatcher} behavior. | ||
* | ||
* @author Artem Bilan | ||
* | ||
* @since 6.1 | ||
*/ | ||
public class PartitionedDispatcher extends AbstractDispatcher { | ||
|
||
private final Map<Integer, UnicastingDispatcher> partitions = new HashMap<>(); | ||
|
||
private final List<ExecutorService> executors = new ArrayList<>(); | ||
|
||
private final int partitionCount; | ||
|
||
private final Function<Message<?>, Object> partitionKeyFunction; | ||
|
||
private ThreadFactory threadFactory = new CustomizableThreadFactory("partition-thread-"); | ||
|
||
private boolean failover = true; | ||
|
||
@Nullable | ||
private LoadBalancingStrategy loadBalancingStrategy; | ||
|
||
private ErrorHandler errorHandler; | ||
|
||
private MessageHandlingTaskDecorator messageHandlingTaskDecorator = task -> task; | ||
|
||
/** | ||
* Instantiate based on a provided number of partitions and function for partition key against | ||
* the message to dispatch. | ||
* @param partitionCount the number of partitions in this channel. | ||
* @param partitionKeyFunction the function to resolve a partition key against the message | ||
* to dispatch. | ||
*/ | ||
public PartitionedDispatcher(int partitionCount, Function<Message<?>, Object> partitionKeyFunction) { | ||
Assert.isTrue(partitionCount > 0, "'partitionCount' must be greater than 0"); | ||
Assert.notNull(partitionKeyFunction, "'partitionKeyFunction' must not be null"); | ||
this.partitionKeyFunction = partitionKeyFunction; | ||
this.partitionCount = partitionCount; | ||
} | ||
|
||
/** | ||
* Set a {@link ThreadFactory} for executors per partitions. | ||
* Defaults to the {@link CustomizableThreadFactory} based on a {@code partition-thread-} prefix. | ||
* @param threadFactory the {@link ThreadFactory} to use. | ||
*/ | ||
public void setThreadFactory(ThreadFactory threadFactory) { | ||
Assert.notNull(threadFactory, "'threadFactory' must not be null"); | ||
this.threadFactory = threadFactory; | ||
} | ||
|
||
/** | ||
* Specify whether partition dispatchers should have failover enabled. | ||
* By default, it will. Set this value to 'false' to disable it. | ||
* @param failover The failover boolean. | ||
*/ | ||
public void setFailover(boolean failover) { | ||
this.failover = failover; | ||
} | ||
|
||
/** | ||
* Provide a {@link LoadBalancingStrategy} for partition dispatchers. | ||
* @param loadBalancingStrategy The load balancing strategy implementation. | ||
*/ | ||
public void setLoadBalancingStrategy(@Nullable LoadBalancingStrategy loadBalancingStrategy) { | ||
this.loadBalancingStrategy = loadBalancingStrategy; | ||
} | ||
|
||
/** | ||
* Provide a {@link ErrorHandler} for wrapping partition {@link Executor} | ||
* to the {@link ErrorHandlingTaskExecutor}. | ||
* @param errorHandler the {@link ErrorHandler} to use. | ||
*/ | ||
public void setErrorHandler(ErrorHandler errorHandler) { | ||
this.errorHandler = errorHandler; | ||
} | ||
|
||
/** | ||
* Set a {@link MessageHandlingTaskDecorator} to wrap a message handling task into some | ||
* addition logic, e.g. message channel may provide an interception for its operations. | ||
* @param messageHandlingTaskDecorator the {@link MessageHandlingTaskDecorator} to use. | ||
*/ | ||
public void setMessageHandlingTaskDecorator(MessageHandlingTaskDecorator messageHandlingTaskDecorator) { | ||
Assert.notNull(messageHandlingTaskDecorator, "'messageHandlingTaskDecorator' must not be null."); | ||
this.messageHandlingTaskDecorator = messageHandlingTaskDecorator; | ||
} | ||
|
||
/** | ||
* Shutdown this dispatcher on application close. | ||
* The partition executors are shutdown and internal state of this instance is cleared. | ||
*/ | ||
public void shutdown() { | ||
this.executors.forEach(ExecutorService::shutdown); | ||
this.executors.clear(); | ||
this.partitions.clear(); | ||
} | ||
|
||
@Override | ||
public boolean dispatch(Message<?> message) { | ||
populatedPartitions(); | ||
int partition = Math.abs(this.partitionKeyFunction.apply(message).hashCode()) % this.partitionCount; | ||
UnicastingDispatcher partitionDispatcher = this.partitions.get(partition); | ||
return partitionDispatcher.dispatch(message); | ||
} | ||
|
||
private synchronized void populatedPartitions() { | ||
if (this.partitions.isEmpty()) { | ||
for (int i = 0; i < this.partitionCount; i++) { | ||
this.partitions.put(i, newPartition()); | ||
} | ||
} | ||
} | ||
|
||
private UnicastingDispatcher newPartition() { | ||
ExecutorService executor = Executors.newSingleThreadExecutor(this.threadFactory); | ||
this.executors.add(executor); | ||
DelegateDispatcher delegateDispatcher = | ||
new DelegateDispatcher(new ErrorHandlingTaskExecutor(executor, this.errorHandler)); | ||
delegateDispatcher.setFailover(this.failover); | ||
delegateDispatcher.setLoadBalancingStrategy(this.loadBalancingStrategy); | ||
delegateDispatcher.setMessageHandlingTaskDecorator(this.messageHandlingTaskDecorator); | ||
return delegateDispatcher; | ||
} | ||
|
||
private final class DelegateDispatcher extends UnicastingDispatcher { | ||
|
||
DelegateDispatcher(Executor executor) { | ||
super(executor); | ||
} | ||
|
||
@Override | ||
protected Set<MessageHandler> getHandlers() { | ||
return PartitionedDispatcher.this.getHandlers(); | ||
} | ||
|
||
@Override | ||
protected boolean tryOptimizedDispatch(Message<?> message) { | ||
return PartitionedDispatcher.this.tryOptimizedDispatch(message); | ||
} | ||
|
||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.