spring-integration-mail minor changes #9948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mjd507
commented
Apr 11, 2025
mjd507
commented
- use pattern matching for instanceof
- polish unit tests
artembilan
requested changes
Apr 11, 2025
There was a problem hiding this comment.
Thank you for contribution!
I'll look into this shortly.
Meanwhile, please, make sure you follow our Checkstyle rules:
Error: eckstyle] [ERROR] /home/runner/work/spring-integration/spring-integration/spring-integration-mail/src/test/java/org/springframework/integration/mail/config/PollingMailSourceParserTests.java:21:1: 'jakarta.mail.URLName' should be separated from previous imports. [ImportOrder]
Error: eckstyle] [ERROR] /home/runner/work/spring-integration/spring-integration/spring-integration-mail/src/test/java/org/springframework/integration/mail/config/PollingMailSourceParserTests.java:25:1: 'org.springframework.beans.DirectFieldAccessor' should be separated from previous imports. [ImportOrder]
> Task :spring-integration-mail:checkstyleTest
Error: eckstyle] [ERROR] /home/runner/work/spring-integration/spring-integration/spring-integration-mail/src/test/java/org/springframework/integration/mail/config/PollingMailSourceParserTests.java:36:58: Using a static member import should be avoided - org.junit.jupiter.params.provider.Arguments.arguments. [AvoidStaticImport]
Error: eckstyle] [ERROR] /home/runner/work/spring-integration/spring-integration/spring-integration-mail/src/test/java/org/springframework/integration/mail/config/MessageWithContentTypeTests.java:22:1: 'jakarta.mail.Session' should be separated from previous imports. [ImportOrder]
Error: eckstyle] [ERROR] /home/runner/work/spring-integration/spring-integration/spring-integration-mail/src/test/java/org/springframework/integration/mail/config/MessageWithContentTypeTests.java:26:1: 'org.springframework.integration.mail.MailHeaders' should be separated from previous imports. [ImportOrder]
Error: eckstyle] [ERROR] /home/runner/work/spring-integration/spring-integration/spring-integration-mail/src/test/java/org/springframework/integration/mail/ImapMailReceiverTests.java:36:1: 'com.icegreen.greenmail.user.GreenMailUser' should be separated from previous imports. [ImportOrder]
Error: eckstyle] [ERROR] /home/runner/work/spring-integration/spring-integration/spring-integration-mail/src/test/java/org/springframework/integration/mail/ImapMailReceiverTests.java:65:1: 'org.springframework.beans.DirectFieldAccessor' should be separated from previous imports. [ImportOrder]
That easy to check locally before pushing changes: gradlew :spring-integration-mail:check
artembilan
requested changes
Apr 11, 2025
...ation-mail/src/main/java/org/springframework/integration/mail/MailSendingMessageHandler.java
Outdated
Show resolved
Hide resolved
...ation-mail/src/main/java/org/springframework/integration/mail/MailSendingMessageHandler.java
Outdated
Show resolved
Hide resolved
...tegration-mail/src/test/java/org/springframework/integration/mail/ImapMailReceiverTests.java
Outdated
Show resolved
Hide resolved
...tegration-mail/src/test/java/org/springframework/integration/mail/ImapMailReceiverTests.java
Outdated
Show resolved
Hide resolved
|
can suggest below test error for core, in my local, it passed. can we re-trigger the build process?
|
1. use pattern matching for instanceof 2. polish unit tests Signed-off-by: Ma,Jiandong <[email protected]>
|
re submitted without change anything, now build pass :) |
|
@mjd507 , thank you for contribution; looking forward for more! |
thank you for such a quick review ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.