Skip to content

If an Error is thrown in the application's @KafkaListener listener code #3843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
artembilan opened this issue Apr 16, 2025 · 1 comment · Fixed by #3845
Closed

If an Error is thrown in the application's @KafkaListener listener code #3843

artembilan opened this issue Apr 16, 2025 · 1 comment · Fixed by #3845
Labels
for: backport-to-3.3.x status: backported type: bug
Milestone
4.0.0-M2

Comments

@artembilan
Copy link
Member

Discussed in #3841

Originally posted by directlx April 15, 2025
If an Error is thrown in the application's @KafkaListener listener code, such as an OOM, Spring Kafka catches this in MessagingMessageListenerAdapter and allows processing to continue, so the offsets are committed, and the message lost. (Unlike for an Exception where the offsets are not committed and message is retried). What is the rationale for this?
@artembilan artembilan added this to the 4.0.0-M2 milestone Apr 16, 2025
@artembilan
Copy link
Member Author

The regression since: #3528

ryanswech pushed a commit to ryanswech/spring-kafka that referenced this issue Apr 16, 2025
Fix MessagingMessageListenerAdapter Error swallowing
12df0d7 
Fixes: spring-projects#3843
@ryanswech ryanswech mentioned this issue Apr 16, 2025
Merged
ryanswech pushed a commit to ryanswech/spring-kafka that referenced this issue Apr 16, 2025
@ryanswech
Fix MessagingMessageListenerAdapter Error swallowing
79ff69f 
Fixes: spring-projects#3843
Signed-off-by: ryanswech <[email protected]>
spring-builds pushed a commit that referenced this issue Apr 16, 2025
@ryanswech @spring-builds
GH-3843: Fix MessagingMessageListenerAdapter Error swallowing
6c0427e 
Fixes: #3843
Issue link: #3843

Signed-off-by: Ryan Swech <[email protected]>

[[email protected] Improve commit message]

Signed-off-by: Artem Bilan <[email protected]>
(cherry picked from commit bef69c3)
@spring-builds spring-builds mentioned this issue Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for: backport-to-3.3.x status: backported type: bug
Projects
None yet
Milestone
4.0.0-M2
Development

Successfully merging a pull request may close this issue.

Fix MessagingMessageListenerAdapter Error swallowing ryanswech/spring-kafka
2 participants
@artembilan @spring-builds