Remove outdated information for transactional.id #2524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare spring-projects#2515 With only EOSMode v2 supported, the alternative way of `transactional.id` creation is not used anymore and not needed anymore. This PR removes the outdated (and confusing) extra documentation in the overview section for transactions.
LukasHeimann
commented
Jan 2, 2023
There was a problem hiding this comment.
The PR currently only includes the minimum necessary change to remove the outdated documentation.
However, I propose to also add two additional sentences of clarification that might be helpful for readers (at least I would have been happy to have them) -- if you feel like they should be included, please let me know or just accept the suggested change.
- Information on how the transactional.id was generated differently in the past. This is useful, as there are many old posts around that discuss this old behavior, so just giving a heads up that you don't have to care is probably nice
- Information on
transactionIdPrefixhaving to be unique per instance of an application. This is mixed up in the discussion of the old way of generation as well: for consumer-initiated transactions it used to be that thetransactionIdPrefixshould be the same for multiple instances, for producer-initiated it must be different. Hence, a small sentence of explanation is probably helpful as well.
Co-authored-by: LukasHeimann <[email protected]>
garyrussell
suggested changes
Jan 9, 2023
garyrussell
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare #2515
With only EOSMode v2 supported, the alternative way of
transactional.idcreation is not used anymore and not needed anymore. This PR removes the outdated (and confusing) extra documentation in the overview section for transactions.