GH-2583 ProducerFactory.createProducer argument @Nullable #2584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
requested changes
Feb 15, 2023
| @@ -56,7 +56,7 @@ | |||
| * @return the producer. | |||
| * @since 2.3 | |||
| */ | |||
| default Producer<K, V> createProducer(@SuppressWarnings("unused") String txIdPrefix) { | |||
| default Producer<K, V> createProducer(@Nullable @SuppressWarnings("unused") String txIdPrefix) { | |||
There was a problem hiding this comment.
Right. It is a @Nullable in the DefaultKafkaProducerFactory.
So, the fix is correct.
Thank you!
spring-kafka/src/test/kotlin/org/springframework/kafka/core/KotlinProducerFactoryTests.kt
Outdated
Show resolved
Hide resolved
spring-kafka/src/test/kotlin/org/springframework/kafka/core/KotlinProducerFactoryTests.kt
Outdated
Show resolved
Hide resolved
|
Did I had to amend my initial commit, or is it ok if requested changes are in second separate commit? |
|
Right. New commit is fully OK. |
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2583
ProducerFactory.createProducer argument txIdPrefix is non-nullable which causes kotlin compiler to emit warning if implementations declare txIdPrefix as nullable txIdPrefix: String?
This PR changes signature of ProducerFactory.createProducer so that
txIdPrefixis@Nullableand also adds unit test to verify compilation, and to verify that future versions of Kotlin won't cause compile errors.Current users of kotlin who implemented ProducerFactory.createProducer(txIdPrefix) with
txIdPrefix: String(non-nullable) will start seeing kotlin compiler warning that their signature is not matching base signature.