Skip to content

Remove outdated comments in ListenerContainerFactoryConfigurer #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove outdated comments in ListenerContainerFactoryConfigurer #2776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e27289
Remove outdated comments in ListenerContainerFactoryConfigurer
WhiteDG Aug 16, 2023
71478a7
Fix unused import
WhiteDG Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...rc/main/java/org/springframework/kafka/retrytopic/ListenerContainerFactoryConfigurer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import org.springframework.kafka.config.KafkaListenerEndpoint;
import org.springframework.kafka.listener.CommonErrorHandler;
import org.springframework.kafka.listener.ConcurrentMessageListenerContainer;
import org.springframework.kafka.listener.ContainerProperties;
import org.springframework.kafka.listener.ContainerProperties.AckMode;
import org.springframework.kafka.listener.DeadLetterPublishingRecoverer;
import org.springframework.kafka.listener.DefaultErrorHandler;
Expand All @@ -46,10 +45,6 @@
* {@link DefaultErrorHandler} and the {@link DeadLetterPublishingRecoverer}
* created by the {@link DeadLetterPublishingRecovererFactory}.
*
* Also sets {@link ContainerProperties#setIdlePartitionEventInterval(Long)}
* and {@link ContainerProperties#setPollTimeout(long)} if its defaults haven't
* been overridden by the user.
*
* Since 2.8.3 these configurations don't interfere with the provided factory
* instance itself, so the same factory instance can be shared among retryable and
* non-retryable endpoints.
Expand Down