Skip to content

cosmetic doc improvements part 4 #2879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

NathanQingyangXu
Copy link
Contributor

final part. feel free to change.

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple questions.
Thanks

@@ -1,5 +1,5 @@
[[sequencing]]
= Starting `@KafkaListener`+++s+++ in Sequence
= Starting `@KafkaListener`s in Sequence
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, what drove you to take your previous change back?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a mistake. updated. thx

@@ -5,26 +5,26 @@ Retry topics and DLT are named by suffixing the main topic with a provided or de

Examples:

"my-topic" -> "my-topic-retry-0", "my-topic-retry-1", ..., "my-topic-dlt"
"my-topic" +++->+++ "my-topic-retry-0", "my-topic-retry-1", ..., "my-topic-dlt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm not sure what is wrong with this arrow:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the special arrow rending seems not intended and the "raw" text seems more desirable. Reverted back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also reverted back a similar change commited previously: 83d1eaf

@artembilan artembilan added this to the 3.1.0 milestone Nov 6, 2023
@artembilan artembilan merged commit b868682 into spring-projects:main Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants