-
Notifications
You must be signed in to change notification settings - Fork 1.6k
cosmetic doc improvements part 4 #2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cosmetic doc improvements part 4 #2879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple questions.
Thanks
@@ -1,5 +1,5 @@ | |||
[[sequencing]] | |||
= Starting `@KafkaListener`+++s+++ in Sequence | |||
= Starting `@KafkaListener`s in Sequence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, what drove you to take your previous change back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a mistake. updated. thx
@@ -5,26 +5,26 @@ Retry topics and DLT are named by suffixing the main topic with a provided or de | |||
|
|||
Examples: | |||
|
|||
"my-topic" -> "my-topic-retry-0", "my-topic-retry-1", ..., "my-topic-dlt" | |||
"my-topic" +++->+++ "my-topic-retry-0", "my-topic-retry-1", ..., "my-topic-dlt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the special arrow rending seems not intended and the "raw" text seems more desirable. Reverted back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also reverted back a similar change commited previously: 83d1eaf
…thanQingyangXu/spring-kafka into feature/ref-improvement-part4
final part. feel free to change.