Skip to content

Handle null group id in listener observation #3778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cfredri4
Copy link
Contributor

@cfredri4 cfredri4 commented Mar 4, 2025

This change fixes an NPE when group id is null and observation is enabled.

@cfredri4 cfredri4 force-pushed the handle-null-group-id-in-listener-observation branch from 9ad7164 to 4335435 Compare March 4, 2025 14:15
@sobychacko
Copy link
Contributor

@cfredri4 Could you add a test verifying this change?

This change fixes an NPE when group id is null and observation is enabled.
Signed-off-by: cfredri4 <[email protected]>
@cfredri4 cfredri4 force-pushed the handle-null-group-id-in-listener-observation branch from 4335435 to 845d3e6 Compare March 5, 2025 12:48
@cfredri4
Copy link
Contributor Author

cfredri4 commented Mar 5, 2025

@sobychacko done.

@sobychacko sobychacko added this to the 4.0.0-M1 milestone Mar 6, 2025
@sobychacko sobychacko merged commit ccf4666 into spring-projects:main Mar 6, 2025
3 checks passed
sobychacko pushed a commit that referenced this pull request Mar 6, 2025
This change fixes an NPE when group id is null and observation is enabled.

Fixes: #3778

Signed-off-by: cfredri4 <[email protected]>

(cherry picked from commit ccf4666)
sobychacko pushed a commit that referenced this pull request Mar 6, 2025
This change fixes an NPE when group id is null and observation is enabled.

Fixes: #3778

Signed-off-by: cfredri4 <[email protected]>

(cherry picked from commit ccf4666)
@cfredri4 cfredri4 deleted the handle-null-group-id-in-listener-observation branch March 6, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants