Skip to content

Meta-annotate @ApplicationModuleTest with @SpringBootTest #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odrotbohm opened this issue Aug 2, 2023 · 0 comments
Closed

Meta-annotate @ApplicationModuleTest with @SpringBootTest #253

odrotbohm opened this issue Aug 2, 2023 · 0 comments
Assignees
@odrotbohm
Labels
in: test support Spring Boot integration testing type: improvement Minor improvements
Milestone
1.0 RC1

Comments

@odrotbohm
Copy link
Member

This is necessary to allow test related auto-configuration to read settings from the @SpringBootTest annotation. See this comment for details.
@odrotbohm odrotbohm added in: test support Spring Boot integration testing type: enhancement Major enhanvements, new features labels Aug 2, 2023
@odrotbohm odrotbohm added this to the 1.0 RC1 milestone Aug 2, 2023
@odrotbohm odrotbohm self-assigned this Aug 2, 2023
odrotbohm added a commit that referenced this issue Aug 2, 2023
@odrotbohm
GH-253 - Let @ApplicationModuleTest be meta-annotated with @SpringBoo…
8c50b3b 
…tTest.

@ApplicationModuleTest is now meta-annotated with @SpringBootTest. This allows us to remove a couple of declarations that we actually had copied from it (such as the TestContextBootstrapper, the SpringExtension etc.)

The presence of the original annotation allow test-related auto-configuration to inspect @SprignBootTest for particular configuration. For example, we now alias the WebEnvironment to make it configurable for the test execution.
@odrotbohm odrotbohm mentioned this issue Aug 2, 2023
Closed
odrotbohm added a commit that referenced this issue Aug 3, 2023
@odrotbohm
GH-253 - Let @ApplicationModuleTest be meta-annotated with @SpringBoo…
3055212 
…tTest.

@ApplicationModuleTest is now meta-annotated with @SpringBootTest. This allows us to remove a couple of declarations that we actually had copied from it (such as the TestContextBootstrapper, the SpringExtension etc.)

The presence of the original annotation allow test-related auto-configuration to inspect @SprignBootTest for particular configuration. For example, we now alias the WebEnvironment to make it configurable for the test execution.
@odrotbohm odrotbohm added type: improvement Minor improvements and removed type: enhancement Major enhanvements, new features labels Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: test support Spring Boot integration testing type: improvement Minor improvements
Projects
None yet
Milestone
1.0 RC1
Development

No branches or pull requests
1 participant
@odrotbohm