Skip to content

Diagnostics are poor when misconfiguration leads to operation-specific configuration being null #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Feb 18, 2019

see more here

@wilkinsona
Copy link
Member

Thanks for the PR. As mentioned in my comment on the Spring Boot issue, the problem isn't specific to WebTestClient. If a change is to be made here, it should be done for MockMvc and REST Assured as well. Would you like to do that as part of this proposal?

@wilkinsona wilkinsona added the status: waiting-for-feedback Feedback is required before progress can be made label Feb 18, 2019
@nosan
Copy link
Contributor Author

nosan commented Feb 18, 2019

@wilkinsona sure, I had some thoughts about this.

@nosan nosan force-pushed the avoid-nullpointer branch 3 times, most recently from 2a7bfb9 to a9c79e7 Compare February 18, 2019 21:26
@nosan
Copy link
Contributor Author

nosan commented Feb 18, 2019

@wilkinsona I added Assert.state(configuration != null) for RestAssured, MockMvc and WebTestClient, but I have a problem with a build:


> Task :restNotesGrailsGradle
> Task :clean
> Task :compileJava NO-SOURCE
> Task :compileGroovy FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileGroovy'.
> javax/servlet/http/HttpServletRequest

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 6s
2 actionable tasks: 2 executed

> Task :restNotesGrailsGradle FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':restNotesGrailsGradle'.
> Process 'command './gradlew'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Also, I had tried to build a master branch, and It was not built as well.

Have I missed something?

@nosan nosan force-pushed the avoid-nullpointer branch from a9c79e7 to 72a0e39 Compare February 18, 2019 21:47
@wilkinsona wilkinsona added type: task Non user-facing work and removed status: waiting-for-feedback Feedback is required before progress can be made status: waiting-for-triage Untriaged issue labels Feb 19, 2019
@wilkinsona wilkinsona added this to the 2.0.4.RELEASE milestone Feb 19, 2019
@wilkinsona wilkinsona added type: bug A bug and removed type: task Non user-facing work labels Feb 19, 2019
@wilkinsona wilkinsona changed the title add Assert.state(configuration) to avoid a NullPointerException. Diagnostics are poor when misconfiguration leads to operation-specific configuration being null Feb 19, 2019
@nosan nosan force-pushed the avoid-nullpointer branch from 72a0e39 to 76a2b0a Compare March 18, 2019 12:48
@nosan nosan force-pushed the avoid-nullpointer branch from 76a2b0a to 7a3ad0b Compare May 2, 2019 14:32
@nosan nosan force-pushed the avoid-nullpointer branch from 7a3ad0b to f5f26f3 Compare July 2, 2019 09:36
wilkinsona pushed a commit that referenced this pull request Aug 30, 2019
wilkinsona added a commit that referenced this pull request Aug 30, 2019
@wilkinsona
Copy link
Member

Thanks for your patience, @nosan, and for your first contribution to Spring REST Docs. The proposed changes have now been merged into master.

@nosan
Copy link
Contributor Author

nosan commented Aug 31, 2019

Everything is ok :) Thanks

@nosan nosan deleted the avoid-nullpointer branch January 28, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants