Skip to content

Allow custom snippets directory via JUnit 5 #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Allow custom snippets directory via JUnit 5 #633

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 9, 2019

With these changes it is possible to specify a custom directory where the snippets are written to if you are using JUnit 5.

@pivotal-issuemaster
Copy link

@nt-jj Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@nt-jj Thank you for signing the Contributor License Agreement!

Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the PR. I've added one small comment. Please take a look and, if you have time and are in agreement, update the proposal accordingly.

@wilkinsona wilkinsona added type: enhancement Enhancement that adds a new feature and removed status: waiting-for-triage Untriaged issue labels Aug 30, 2019
@wilkinsona wilkinsona added this to the 2.0.4.RELEASE milestone Aug 30, 2019
wilkinsona pushed a commit that referenced this pull request Aug 30, 2019
wilkinsona added a commit that referenced this pull request Aug 30, 2019
@wilkinsona
Copy link
Member

Thanks very much for the PR. The proposed changes are now in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Enhancement that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants