Section number incremented when it shouldn't #638
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nding it to the parent
ahus1
changed the title
|
I've updated an existing test case to cover also the chapter numbering. As this has now a test, I removed the WIP. |
wilkinsona
added
type: task
wilkinsona
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Sep 19, 2019
wilkinsona
added a commit
that referenced
this pull request
Sep 19, 2019
|
Thanks again, @ahus1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My pull request for #628 introduced a regression: when using numbered sections using :sectnums: this produced gaps in the chapter number.
I traced it down to the following issue: when the block is created, it is assigned a "sectname". For "==" this is "chapter", and it will increase the chapter number.
This change now sets level and sectname from a temporary template node. This leads to the correct sectname, and no chapter number will be increased.
I see that #628 has been picked for the next maintenance release; maybe you want to revert/postpone it in the branch until this is taken care of.
I marked this [WIP] as it is missing a test.