Skip to content

Warnings logged by the operation block macro lack context #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Warnings logged by the operation block macro lack context #699

wants to merge 1 commit into from

Conversation

ahus1
Copy link
Contributor

@ahus1 ahus1 commented Oct 3, 2020

I'm backporting a change that I applied in the IntelliJ AsciiDoc plugin to highlight problems with the operation macro in the editor.

When using logger.warn with a cursor the output contains the file and line number where the problem occurred.

The unit tests will log an example output like this (from a unit test)

WARNING: <stdin>: line 1: Snippet missing-snippet not found at C:\Users\...\AppData\Local\Temp\junit8239829976219138844\gradle-project\build\generated-snippets/some-operation/missing-snippet.adoc for operation some-operation

@wilkinsona wilkinsona added type: bug A bug and removed status: waiting-for-triage Untriaged issue labels Oct 30, 2020
@wilkinsona wilkinsona added this to the 2.0.6.RELEASE milestone Oct 30, 2020
@wilkinsona wilkinsona changed the title operation macro should log the location where the problem occurred Warnings logged by the operation block macro lack context Nov 13, 2020
@wilkinsona
Copy link
Member

Thanks very much, @ahus1.

@ahus1 ahus1 deleted the add-line-numbers-to-warnings branch November 13, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants