Skip to content

JwtTimeStampValidator uses wrong error on token expiration #10319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jason076 opened this issue Sep 24, 2021 · 1 comment
Closed

JwtTimeStampValidator uses wrong error on token expiration #10319

jason076 opened this issue Sep 24, 2021 · 1 comment
Assignees
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone

Comments

@jason076
Copy link
Contributor

Summary

I think the JwtTimeStampValidator uses the wrong error type when a token expires:

As listed in https://datatracker.ietf.org/doc/html/rfc6750#section-3.1 it should use INVALID_TOKEN error.

Actual Behavior

JwtTimeStampValidator uses INVALID_REQUEST error when a token expires

Expected Behavior

JwtTimeStampValidator should uses INVALID_TOKEN error when a token expires

Version

5.5.2

Sample

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 24, 2021
@eleftherias eleftherias added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 24, 2021
@jzheaux jzheaux added the type: bug A general bug label Sep 28, 2021
@jzheaux jzheaux added this to the 5.6.0-RC1 milestone Sep 28, 2021
jzheaux added a commit that referenced this issue Sep 28, 2021
@spring-projects-issues spring-projects-issues added the status: backported An issue that has been backported to maintenance branches label Sep 28, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Sep 28, 2021

Thanks for the report, @jason076. This has now been fixed in main and backported to 5.5.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Development

No branches or pull requests

4 participants