Skip to content

Documentation has wrong code example in the 'Customizing OpenSAML’s AuthnRequest Instance' section #10364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nyszilard opened this issue Oct 12, 2021 · 2 comments
Closed

Documentation has wrong code example in the 'Customizing OpenSAML’s AuthnRequest Instance' section #10364

nyszilard opened this issue Oct 12, 2021 · 2 comments
Assignees
@nor-ek
Labels
in: saml2 An issue in SAML2 modules status: backported An issue that has been backported to maintenance branches type: bug A general bug

Comments

@nyszilard
Copy link

In the Customizing OpenSAML’s AuthnRequest Instance section the code example is wrong, because:

  • There is no parameterless DefaultSaml2AuthenticationRequestContextResolver constructor
  • OpenSamlAuthenticationRequestFactory is deprecated, so it should use OpenSaml4AuthenticationRequestFactory instead
  • It should use Converter<Saml2AuthenticationRequestContext, AuthnRequest> instead of Converter<MySaml2AuthenticationRequestContext, AuthnRequest>
@nyszilard nyszilard added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Oct 12, 2021
@nor-ek
Copy link
Contributor

nor-ek commented Oct 13, 2021

If you won't I can work on this.

@jzheaux jzheaux added in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 13, 2021
@nor-ek
Copy link
Contributor

nor-ek commented Nov 1, 2021

Hey @nyszilard here is the pull request #10463. I'm not sure about resolver creation example.

nor-ek added a commit to nor-ek/spring-security that referenced this issue Nov 5, 2021
@nor-ek
Correct converter usage in Customizing OpenSAML’s AuthnRequest Instan…
6949e85 
…ce documentation section

spring-projectsgh-10364 use Converter<Saml2AuthenticationRequestContext, AuthnRequest> instead of Converter<MySaml2AuthenticationRequestContext, AuthnRequest>
jzheaux pushed a commit that referenced this issue Nov 18, 2021
@nor-ek @jzheaux
Fix AuthnRequestConverter Sample Typos
02cd1dd 
Closes gh-10364
jzheaux pushed a commit that referenced this issue Nov 18, 2021
@nor-ek @jzheaux
Fix AuthnRequestConverter Sample Typos
1c0f092 
Closes gh-10364
jzheaux added a commit that referenced this issue Nov 18, 2021
@jzheaux
Polish AuthRequestConverter Sample Doc
2dac210 
Issue gh-10364
jzheaux added a commit that referenced this issue Nov 18, 2021
@jzheaux
Polish AuthRequestConverter Sample Doc
739cdc1 
Issue gh-10364
jzheaux added a commit that referenced this issue Nov 18, 2021
@jzheaux
Polish AuthRequestConverter Sample Doc
16a2126 
Issue gh-10364
jzheaux added a commit that referenced this issue Nov 18, 2021
@jzheaux
Fix AuthnRequestConverter Sample Typos
c495ff8 
Closes gh-10364
@spring-projects-issues spring-projects-issues added the status: backported An issue that has been backported to maintenance branches label Nov 18, 2021
Closed
jzheaux added a commit that referenced this issue Nov 18, 2021
@jzheaux
Fix AuthnRequestConverter Sample Typos
bd42939 
Closes gh-10364
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nor-ek nor-ek

Labels
in: saml2 An issue in SAML2 modules status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jzheaux @spring-projects-issues @nyszilard @nor-ek