Skip to content

Kotlin DSL examples in reactive oauth2 docs call build twice #10580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sjohnr opened this issue Dec 1, 2021 · 0 comments · Fixed by #10586
Closed

Kotlin DSL examples in reactive oauth2 docs call build twice #10580

sjohnr opened this issue Dec 1, 2021 · 0 comments · Fixed by #10586
Assignees
Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone

Comments

@sjohnr
Copy link
Member

sjohnr commented Dec 1, 2021

This issue addresses incorrect usage of the Kotlin DSL related to documentation improvements under gh-8174.

    @Bean
    fun securityFilterChain(http: ServerHttpSecurity): SecurityWebFilterChain {
        http {
            ...
        }

        return http.build()
    }

Should be:

    @Bean
    fun securityFilterChain(http: ServerHttpSecurity): SecurityWebFilterChain {
        return http {
            ...
        }
    }
@sjohnr sjohnr added in: docs An issue in Documentation or samples type: bug A general bug labels Dec 1, 2021
@sjohnr sjohnr self-assigned this Dec 1, 2021
@sjohnr sjohnr changed the title Correct Kotlin DSL examples in reactive oauth docs Kotlin DSL examples in reactive oauth2 docs call build twice Dec 1, 2021
sjohnr pushed a commit to sjohnr/spring-security that referenced this issue Dec 3, 2021
@sjohnr sjohnr added this to the 5.7.0-M1 milestone Dec 3, 2021
eleftherias pushed a commit that referenced this issue Dec 6, 2021
eleftherias pushed a commit that referenced this issue Dec 7, 2021
eleftherias pushed a commit that referenced this issue Dec 7, 2021
@spring-projects-issues spring-projects-issues added the status: backported An issue that has been backported to maintenance branches label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants