-
Notifications
You must be signed in to change notification settings - Fork 6k
No introduction to CachingUserDetailsService in the documentation #10914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@linghengqian, thanks for the suggestion. I think many don't know of this class, and personally I have always used Spring's |
I just realized |
@linghengqian, no problem, thanks for the update. |
Hello, may I take this task, please? |
Sure! |
@timofeli Any updates? |
Hello, I'd like to take this issue, if it's ok for you. According to the discussion in this thread, the idea is to recommend using |
Thanks!
I don't think we need to deprecate this class. However, the documentation could show an example of how to use it (declare it as a |
Expected Behavior
There should be a subsection in https://docs.spring.io/spring-security/reference/ describing
org.springframework.security.authentication.CachingUserDetailsService
.Current Behavior
In fact there is no such text passage to mention this class.
Context
This class does not give too much description in the javadoc, and some people use outdated information to judge the role of this class in the closed issues, for example #2837 .
According to the discussion on Stack Overflow (refer to https://stackoverflow.com/questions/40766098/springcachebasedusercache-is-null ), it seems that many people have the need to cache authentication information, but the official website documentation is not mentioned this class. Should it be mentioned if possible?
Because the function of this class is relatively intuitive and simple, is it the opinion of the community that it is not recommended to use this class? If so, then I think it should be explained in the documentation.
The text was updated successfully, but these errors were encountered: