Skip to content

SAML logout: Incorrect log messages #12129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
palakova opened this issue Nov 2, 2022 · 1 comment
Closed

SAML logout: Incorrect log messages #12129

palakova opened this issue Nov 2, 2022 · 1 comment
Assignees
@jzheaux
Labels
in: saml2 An issue in SAML2 modules status: waiting-for-triage An issue we've not yet triaged type: bug A general bug

Comments

@palakova
Copy link
Contributor

palakova commented Nov 2, 2022

Describe the bug
There are following incorrect log messages, referring to Response instead of Request and vice versa:

OpenSamlLogoutRequestValidator

  • "Failed to find issuer in LogoutResponse"
  • "Failed to find destination in LogoutResponse"

Saml2LogoutResponseFilter

  • "Did not process logout request since failed to find associated RelyingPartyRegistration"
@palakova palakova added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Nov 2, 2022
palakova added a commit to palakova/spring-security that referenced this issue Nov 2, 2022
@palakova
Fix SAML logout log messages
774524c 
Fixes SAML logout log messages incorrectly referring to logout
response instead of logout request and vice versa.

Closes spring-projectsgh-12129
@palakova palakova mentioned this issue Nov 2, 2022
Merged
@palakova
Copy link
Contributor Author

palakova commented Nov 2, 2022

I created PR #12130 to fix this issue. Please feel free to review.

@sjohnr sjohnr added the in: saml2 An issue in SAML2 modules label Nov 2, 2022
@jzheaux jzheaux mentioned this issue Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: saml2 An issue in SAML2 modules status: waiting-for-triage An issue we've not yet triaged type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jzheaux @sjohnr @palakova