You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CookieRequestCache should set SameSite on the REDIRECT_URI cookie #15204
Describe the bug
When using CookieRequestCache, Firefox complains:
Cookie “REDIRECT_URI” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite
To Reproduce
Configure your application to use CookieRequestCache, like so:
I believe that we could add some kind of customizer to the cookie in the CookieRequestCache implementation, similar to #15203, what do you think?
I don't think that we should set a default value to that attribute tho, since the docs mention that the attribute is optional and, if not provided, a default value (defined by the browser) will be used.
Activity
marcusdacoregio commentedon Jun 10, 2024
Hi @2is10, thanks for the report.
I believe that we could add some kind of customizer to the cookie in the
CookieRequestCacheimplementation, similar to #15203, what do you think?I don't think that we should set a default value to that attribute tho, since the docs mention that the attribute is optional and, if not provided, a default value (defined by the browser) will be used.
Add cookie customizer to CookieRequestCache
Add cookie customizer to CookieRequestCache
Add cookie customizer to CookieRequestCache and CookieServerRequestCache
Add cookie customizer to CookieRequestCache and CookieServerRequestCache
Add cookie customizer to CookieRequestCache and CookieServerRequestCache
marcusdacoregio commentedon Sep 3, 2024
Closed via #15685