-
Notifications
You must be signed in to change notification settings - Fork 6k
CookieRequestCache should set SameSite on the REDIRECT_URI cookie #15204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Hi @2is10, thanks for the report. I believe that we could add some kind of customizer to the cookie in the I don't think that we should set a default value to that attribute tho, since the docs mention that the attribute is optional and, if not provided, a default value (defined by the browser) will be used. |
fb64
added a commit
to fb64/spring-security
that referenced
this issue
Aug 23, 2024
fb64
added a commit
to fb64/spring-security
that referenced
this issue
Aug 29, 2024
fb64
added a commit
to fb64/spring-security
that referenced
this issue
Aug 31, 2024
fb64
added a commit
to fb64/spring-security
that referenced
this issue
Aug 31, 2024
marcusdacoregio
pushed a commit
that referenced
this issue
Sep 3, 2024
Closed via #15685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When using CookieRequestCache, Firefox complains:
To Reproduce
Configure your application to use CookieRequestCache, like so:
Note that due to #2932 you likely also need to separately pass the CookieRequestCache to SavedRequestAwareAuthenticationSuccessHandler.
Expected behavior
No warning in Firefox. The POST /login request should also not show up as “blocked”.
Sample
No sample provided. This is easy to try on any project.
The text was updated successfully, but these errors were encountered: