Skip to content

One time token authentication filter should be its own class #16539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kehrlann opened this issue Feb 5, 2025 · 0 comments
Closed

One time token authentication filter should be its own class #16539

Kehrlann opened this issue Feb 5, 2025 · 0 comments
Assignees
@rwinch
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Milestone
6.5.0-M2

Comments

@Kehrlann
Copy link
Contributor

Kehrlann commented Feb 5, 2025 •
edited
Loading

Expected Behavior

Authentication processing for one-time login token should happen in a dedicated filter class.

(Discussed with @rwinch)

Current Behavior

Authentication processing happens in an undifferentiated instance of AuthenticationFilter, see OneTimeTokenLoginConfigurer.

Context

This will help implement gh-16414 .
@Kehrlann Kehrlann added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Feb 5, 2025
Kehrlann added a commit to Kehrlann/spring-security that referenced this issue Feb 5, 2025
@Kehrlann
Introduce OneTimeTokenAuthenticationFilter
2d72856 
closes spring-projectsgh-16539

Signed-off-by: Daniel Garnier-Moiroux <[email protected]>
@Kehrlann Kehrlann mentioned this issue Feb 5, 2025
Merged
@rwinch rwinch closed this as completed in 5ee6b83 Feb 10, 2025
@rwinch rwinch self-assigned this Feb 10, 2025
@rwinch rwinch added in: web An issue in web modules (web, webmvc) and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 10, 2025
@rwinch rwinch added this to the 6.5.0-M2 milestone Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
6.5.0-M2
Development

No branches or pull requests
2 participants
@rwinch @Kehrlann