Consider moving CommonOAuth2Provider to Spring Security

[mbhave]

Instead of using spring-security-oauth2-client-templates.properties for common provider defaults, we updated the auto-config in Boot to use this. This seems like it could live in Spring Security instead of the properties file.

[philwebb]

Even if CommonOAuth2Provider doesn't move I think that spring-security-oauth2-client-templates.properties should be deleted. It feels odd that there is a property file in Spring Security that defines keys in Spring Boot form.

[jgrandja]

@philwebb I added spring-security-oauth2-client-templates.properties to Spring Security based on my PR review comment and this comment.

However, given that a different approach was taken in the recent PR, spring-security-oauth2-client-templates.properties will be removed from Spring Security.

[philwebb]

@jgrandja Yeah, and still think it makes sense to have those default in Spring Security in case users want them without Spring Boot. I'm just don't think we should use the property name format from Boot (in case we want to evolve it).

[jgrandja]

Related #4598

[jgrandja]

@philwebb I'll take care of this at some point next week.

[jgrandja]

Thanks for the contribution @philwebb ! Much nicer approach vs. properties file. This is now in master.