ConversionService should be configurable for BasicLookupStrategy and JdbcAclService

[pwheel]

Summary

In #4424 I added AclClassIdUtils to handle some common logic for dealing with acl classes with types other than Long. I thought this class would be internal, then decided it was better to have it explicitly defined.

The class has package level visibility, but should be public.

Actual Behavior

Unable to define a bean of type AclClassIdUtils using Java Config as the class is not public.

Expected Behavior

Should be able to define a bean of type AclClassIdUtils using Java Config.

Configuration

@Bean
public AclClassIdUtils aclClassIdUtils() {

    AclClassIdUtils classIdUtils = new AclClassIdUtils();
    classIdUtils.setConversionService(new DefaultConversionService());
    
    return classIdUtils
}

UPDATE: This ticket's proposal changed during the time it was being implemented. Instead of exposing AclClassIdUtils as public, it was resolved to make BasicLookupStrategy and JdbcAclService expose setConversionService which they'd ultimately provide to AclClassIdUtils.

For example in BasicLookupStrategy doing:

public void setConversionService(ConversionService conversionService) {
    this.aclClassIdUtils = new AclClassIdUtils(conversionService);
}

In this way, #4424 is addressed while still keeping AclClassIdUtils package-private.

[mehdichitforoosh]

Hi.
@pwheel when this issue will be closed?
I need to use ConversionService in AclClassIdUtils in java config but i can't because it is internal.
I see also issue #4424 ,It seems the problem still exists...
Thanks.

[Thorn1089]

Any movement on this? I'd also mention that #4424 is not truly solved in my opinion. On Postgres, using a UUID causes an error because the queries to check for existing IDs attempt to cast between a proper UUID type in Postgres and the varchar column definition in the included schemas.

If schemas are going to be included with the library, they should work out of the box, is my expectation. If not, then make it clear I need to write a MutableAclService from scratch. As is I've wasted two days trying to get JdbcMutableAclService to work with non-Long identifiers.

[nenaraab]

Hi, i still have the issue to inject a ConversionService into the AclClassIdUtils class. The AclClassIdUtils class itself can not be instantiated as it is package protected. It can not be overwritten, as there is no interface defined...

My problem:

• in my case, my acl_object_identity.object_id_identity can be of type java.lang.Long (no issue), java.lang.String and UUID.
• Therefore I've introduced the column class_id_type in table acl_class
• I've added setAclClassIdSupported(true) to both my BasicLookupStrategy and JdbcMutableAclService
• But, even in case of ids of type String (!) i run finally into NumberFormatException, because the conversionService is null in AclClassIdUtils (same as documented here) and finally it is unable to convert the id of type String to String...
• Anyhow... in any case, String or UUID I'm unable to provide/inject a ConversionService to the BasicLookupStrategy or finally into the AclClassIdUtils class.

My questions:

• This commit looks promising. But it seems not (yet?) be merged into master.
• Any other workaround, especially for object-id of type String?

References

• related issue: Allow use of non-numeric (e.g. UUID) values for ObjectIdentity.getIdentifier() #4424
• related commit: pwheel@8efec02

[rwinch]

@nenaraab Thanks for the bump. The PR is now merged into master. Can you give it a try? You will be able to find the SNAPSHOT in about 30 minutes in the https://repo.spring.io/libs-snapshot Maven repository