Skip to content

Provide XML namespace support for OAuth 2.0 Client #5184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgrandja opened this issue Mar 29, 2018 · 4 comments
Closed

Provide XML namespace support for OAuth 2.0 Client #5184

jgrandja opened this issue Mar 29, 2018 · 4 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.3.0

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Mar 29, 2018 •
edited
Loading

We should consider providing XML namespace support that is equivalent to HttpSecurity.oauth2Client().

NOTE: Spring Security OAuth 2.x implements this via ResourceBeanDefinitionParser. See the sample xml config.

Related #4557 #5185
@jgrandja jgrandja added Namespace in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Mar 29, 2018
@jgrandja jgrandja added this to the 5.1.0.M2 milestone Mar 29, 2018
@jgrandja jgrandja removed this from the 5.1.0.M2 milestone May 26, 2018
@rwinch rwinch added type: enhancement A general enhancement and removed in: config An issue in spring-security-config Namespace labels May 3, 2019
@tiwatsuka tiwatsuka mentioned this issue Nov 18, 2019
Closed
@jgrandja jgrandja added this to the 5.3.x milestone Nov 18, 2019
@jgrandja jgrandja mentioned this issue Feb 12, 2020
Closed
@rh-id
Copy link
Contributor

rh-id commented Feb 17, 2020

@jgrandja I think i might as well take this. if i may ask currently, still no due date for this?

@jgrandja jgrandja modified the milestones: 5.3.x, 5.3.0 Feb 18, 2020
@jgrandja jgrandja self-assigned this Feb 18, 2020
@jgrandja
Copy link
Contributor Author

@rh-id Ideally, I'd like to get this into 5.3 which is due March 4. However, I'm off for a few days from Feb 26 which means I need to get this merged no later than Feb 24-25. The timeline is very tight so I would completely understand if you do not have the time to complete it this week or by Mon Feb 24. I do have time this week myself to complete it so there is no pressure. Either way, let me know so there is no duplication of effort. Thank you.

@rh-id
Copy link
Contributor

rh-id commented Feb 18, 2020

@jgrandja sorry, i'll have to pass then.

@jgrandja
Copy link
Contributor Author

No worries @rh-id. Feel free to browse the open issues at anytime you are free and interested in picking up another issue and let me know. Talk soon.

jgrandja added a commit that referenced this issue Feb 21, 2020
@jgrandja
Polish gh-5184
4cd89b5
@jzheaux jzheaux mentioned this issue Mar 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.0
Development

No branches or pull requests
3 participants
@rwinch @jgrandja @rh-id