Skip to content

OAuth2UserService should set Accept header to JSON #5294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgrandja opened this issue May 3, 2018 · 0 comments
Closed

OAuth2UserService should set Accept header to JSON #5294

jgrandja opened this issue May 3, 2018 · 0 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Milestone
5.1.0.M1

Comments

@jgrandja
Copy link
Contributor

jgrandja commented May 3, 2018

The OAuth2UserService implementations use NimbusUserInfoResponseClient to fetch the UserInfo resource and converts the response to a Map using MappingJackson2HttpMessageConverter.

NimbusUserInfoResponseClient should explicitly set the Accept header to application/json as some provider's may default the content-type to another format other than JSON, for example, XML.
@jgrandja jgrandja self-assigned this May 3, 2018
@jgrandja jgrandja added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels May 3, 2018
@jgrandja jgrandja added this to the 5.1.0.M1 milestone May 3, 2018
@jgrandja jgrandja added in: web An issue in web modules (web, webmvc) OIDC labels May 3, 2018
@jgrandja jgrandja mentioned this issue May 3, 2018
Closed
jgrandja added a commit that referenced this issue May 4, 2018
@jgrandja
Add test NimbusUserInfoResponseClient sets Accept header to JSON
2356749 
Issue gh-5294
jgrandja added a commit that referenced this issue May 4, 2018
@jgrandja
NimbusUserInfoResponseClient sets Accept header to JSON
e1e4643 
Fixes gh-5294
jgrandja added a commit that referenced this issue May 4, 2018
@jgrandja
Add test NimbusUserInfoResponseClient sets Accept header to JSON
f524da3 
Issue gh-5294
YuchangLi added a commit to YuchangLi/spring-security that referenced this issue May 4, 2018
@YuchangLi
upgrade (#2)
c580069 
* Update GAE 1.9.63

Fixes: spring-projectsgh-5277

* Update Spring Boot 2.0.1.RELEASE

Fixes: spring-projectsgh-5278

# Conflicts:
#	gradle.properties

* Update to nimbus-jose-jwt:5.10

Fixes: spring-projectsgh-5279

* Update to oauth2-oidc-sdk:5.61

Fixes: spring-projectsgh-5280

* Update to javax.servlet-api:4.0.1

Fixes: spring-projectsgh-5281

* Update to aspectj 1.9.1

Fixes: spring-projectsgh-5282

* Update to htmlunit:2.30

Fixes: spring-projectsgh-5283

* Update to mockito-core:2.18.3

Fixes: spring-projectsgh-5284

* Update to selenium 3.11.0

Fixes: spring-projectsgh-5289

* Update to Spring Framework 5.0.6.BUILD-SNAPSHOT

Issue: spring-projectsgh-5290

# Conflicts:
#	gradle/dependency-management.gradle

* Add update-dependencies.sh

Fixes: spring-projectsgh-5276

* Improve PasswordEncoder deprecated notices

Fixes: spring-projectsgh-5296

* NimbusUserInfoResponseClient sets Accept header to JSON

Fixes spring-projectsgh-5294

* Add test NimbusUserInfoResponseClient sets Accept header to JSON

Issue spring-projectsgh-5294

* Improve ClaimAccessor getClaimAsInstant

Fixes spring-projectsgh-5250

* Fix incorrect explanation for customizing query on JdbcDaoImpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
5.1.0.M1
Development

No branches or pull requests
1 participant
@jgrandja