Skip to content

Created exception is not throwing #5462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
milovtim opened this issue Jun 26, 2018 · 1 comment
Closed

Created exception is not throwing #5462

milovtim opened this issue Jun 26, 2018 · 1 comment

Comments

@milovtim
Copy link

Summary

Exception object was created but not throwing (and not used later).

Actual Behavior

It some sort of programmer's typo: create exception object and forget it

Expected Behavior

An exception must propagate to caller in order DigestAuthenticationFilter to work properly

Configuration

No configuration required -- it's obvious code-level mistake.

Version

Found in latest 5.1.0.M1. Still exists in earlier versions and in master for the moment issue was created.

Sample

link to line in class
@ThomasVitale
Copy link
Contributor

I'd like to fix this issue

@ThomasVitale ThomasVitale mentioned this issue Mar 10, 2019
Closed
jzheaux added a commit that referenced this issue Apr 14, 2019
@jzheaux
Improved DigestAuthenticationFilter Test Coverage
20a7bc4 
Issue: gh-5462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throw exception that was created but not thrown
2 participants
@milovtim @ThomasVitale