Skip to content

OAuth2LoginAuthenticationProvider uses OAuth2AuthorizationCodeAuthenticationProvider #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgrandja opened this issue Aug 2, 2018 · 7 comments
Closed

OAuth2LoginAuthenticationProvider uses OAuth2AuthorizationCodeAuthenticationProvider #5633

jgrandja opened this issue Aug 2, 2018 · 7 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.4.0-M1

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Aug 2, 2018

The OAuth2LoginAuthenticationProvider performs most of the same logic that exists in OAuth2AuthorizationCodeAuthenticationProvider. We should re-factor to allow for reuse.
@jgrandja jgrandja added type: enhancement A general enhancement Refactoring in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Aug 2, 2018
@jgrandja jgrandja added this to the 5.1.0.RC1 milestone Aug 2, 2018
@rwinch
Copy link
Member

rwinch commented Aug 2, 2018

Related to this is that OAuth2LoginAuthenticationToken could extend OAuth2AuthorizationCodeAuthenticationToken which seems logical and would allow the existing OAuth2 Log In code to be passive.

@jgrandja jgrandja modified the milestones: General Backlog, 5.1.x Oct 19, 2018
@rwinch rwinch removed the Refactoring label May 3, 2019
@jgrandja jgrandja self-assigned this May 21, 2019
@jgrandja jgrandja removed their assignment Jun 4, 2019
@jgrandja jgrandja mentioned this issue Jul 17, 2019
Closed
@pdelert
Copy link

pdelert commented Sep 2, 2019

@jgrandja @rwinch can I take this enhancement ?

@jgrandja
Copy link
Contributor Author

jgrandja commented Sep 3, 2019

@pdelert That would be great! Thank you.

@pdelert
Copy link

pdelert commented Sep 4, 2019 •
edited
Loading

@jgrandja please have a look here #7356

@jgrandja jgrandja mentioned this issue Sep 10, 2019
Closed
@jgrandja jgrandja self-assigned this Sep 30, 2019
@rh-id
Copy link
Contributor

rh-id commented Mar 4, 2020

hi @jgrandja , @pdelert . do you mind if i takeover this issue?

@jgrandja
Copy link
Contributor Author

jgrandja commented Mar 4, 2020

That would be great @rh-id. But let's wait for confirmation from @pdelert as they have an open PR #7356 but I haven't heard back from them in a while. Please wait 1-2 weeks for a confirmation and if we don't hear from them then go ahead with the PR. Thanks!

@rh-id
Copy link
Contributor

rh-id commented Mar 22, 2020

hi @jgrandja i had created PR #8170

@jgrandja jgrandja modified the milestones: 5.1.x, 5.4.0.M1 Mar 31, 2020
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x labels Mar 31, 2020
Closed
Closed
Closed
jgrandja pushed a commit that referenced this issue Mar 31, 2020
@rh-id @jgrandja
Improve OAuth2LoginAuthenticationProvider
45eb34c 
1. update OAuth2LoginAuthenticationProvider to use
OAuth2AuthorizationCodeAuthenticationProvider
2. apply fix gh-5368 for OAuth2AuthorizationCodeAuthenticationProvider
to return additionalParameters value from accessTokenResponse

Fixes gh-5633
jgrandja pushed a commit that referenced this issue Mar 31, 2020
@rh-id @jgrandja
Improve OAuth2LoginAuthenticationProvider
401597c 
1. update OAuth2LoginAuthenticationProvider to use
OAuth2AuthorizationCodeAuthenticationProvider
2. apply fix gh-5368 for OAuth2AuthorizationCodeAuthenticationProvider
to return additionalParameters value from accessTokenResponse

Fixes gh-5633
jgrandja pushed a commit that referenced this issue Mar 31, 2020
@rh-id @jgrandja
Improve OAuth2LoginAuthenticationProvider
19f08cb 
1. update OAuth2LoginAuthenticationProvider to use
OAuth2AuthorizationCodeAuthenticationProvider
2. apply fix gh-5368 for OAuth2AuthorizationCodeAuthenticationProvider
to return additionalParameters value from accessTokenResponse

Fixes gh-5633
@ghojeong ghojeong mentioned this issue Feb 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-M1
Development

No branches or pull requests
5 participants
@rwinch @pdelert @jgrandja @spring-projects-issues @rh-id