Skip to content

OAuth2AuthorizationCodeGrantWebFilter works with /{action}/ #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Sep 17, 2018 · 0 comments
Closed

OAuth2AuthorizationCodeGrantWebFilter works with /{action}/ #5856

rwinch opened this issue Sep 17, 2018 · 0 comments
Assignees
@rwinch
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Milestone
5.1.0

Comments

@rwinch
Copy link
Member

rwinch commented Sep 17, 2018

Summary

This ensures that the same URL can work for both log in and
authorization code which prevents having to create additional registrations
on the client and potentially on the server (GitHub only allows a single
valid redirect URL).
@rwinch rwinch added Reactive in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Sep 17, 2018
@rwinch rwinch added this to the 5.1.0 milestone Sep 17, 2018
@rwinch rwinch self-assigned this Sep 17, 2018
@rwinch rwinch closed this as completed in 385bdfc Sep 18, 2018
rwinch added a commit that referenced this issue Sep 21, 2018
@rwinch
Fix OAuth2AuthorizationCodeGrantWebFilter works w/ /{action/
725b3b5 
Issue: gh-5856
@rwinch rwinch mentioned this issue Nov 21, 2018
Closed
jgrandja added a commit that referenced this issue Jun 19, 2019
@jgrandja
Revert OAuth2AuthorizationCodeGrantWebFilter works with /{action}/
6e76df8 
Issue #5856
Commit 385bdfc

NOTE: This commit 'partially' reverts #5856. Only the ServerWebExchangeMatcher for OAuth2LoginSpec is reverted.

Fixes gh-6890
jgrandja added a commit that referenced this issue Jun 19, 2019
@jgrandja
Revert OAuth2AuthorizationCodeGrantWebFilter works with /{action}/
b0597f4 
Issue #5856
Commit 385bdfc

NOTE: This commit 'partially' reverts #5856. Only the ServerWebExchangeMatcher for OAuth2LoginSpec is reverted.

Fixes gh-6890
kostya05983 pushed a commit to kostya05983/spring-security that referenced this issue Aug 26, 2019
@jgrandja @kostya05983
Revert OAuth2AuthorizationCodeGrantWebFilter works with /{action}/
f0d3ad5 
Issue spring-projects#5856
Commit 385bdfc

NOTE: This commit 'partially' reverts spring-projects#5856. Only the ServerWebExchangeMatcher for OAuth2LoginSpec is reverted.

Fixes spring-projectsgh-6890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
1 participant
@rwinch