Skip to content

OAuth2LoginAuthenticationFilter should ignore authenticated requests #5915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Oct 3, 2018 · 0 comments
Closed

OAuth2LoginAuthenticationFilter should ignore authenticated requests #5915

rwinch opened this issue Oct 3, 2018 · 0 comments
Assignees
@rwinch
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Milestone
5.1.1

Comments

@rwinch
Copy link
Member

rwinch commented Oct 3, 2018

Summary

Rather than trying to authenticate again, the OAuth2LoginAuthenticationFilter should ignore authenticated requests. This enables getting an access token using an authorization code flow after authenticating using another mechanism (i.e. username/password).
@rwinch rwinch added this to the 5.1.1 milestone Oct 3, 2018
@rwinch rwinch added the in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) label Oct 3, 2018
@philwebb philwebb mentioned this issue Oct 3, 2018
Closed
@jgrandja jgrandja modified the milestones: 5.1.1, 5.1.x Oct 12, 2018
@jgrandja jgrandja removed their assignment Oct 12, 2018
@rwinch rwinch modified the milestones: 5.1.x, 5.1.1 Oct 12, 2018
@rwinch rwinch self-assigned this Oct 12, 2018
@rwinch rwinch added the type: bug A general bug label Oct 12, 2018
@rwinch rwinch closed this as completed in 93ca455 Oct 12, 2018
jgrandja added a commit that referenced this issue Jun 19, 2019
@jgrandja
Revert OAuth2LoginAuthenticationFilter should ignore authenticated re…
06943d2 
…quests

Issue #5915
Commit 93ca455

Fixes gh-6890
jgrandja added a commit that referenced this issue Jun 19, 2019
@jgrandja
Revert OAuth2LoginAuthenticationFilter should ignore authenticated re…
efe64aa 
…quests

Issue #5915
Commit 93ca455

Fixes gh-6890
kostya05983 pushed a commit to kostya05983/spring-security that referenced this issue Aug 26, 2019
@jgrandja @kostya05983
Revert OAuth2LoginAuthenticationFilter should ignore authenticated re…
237a6fe 
…quests

Issue spring-projects#5915
Commit 93ca455

Fixes spring-projectsgh-6890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Projects
None yet
Milestone
5.1.1
Development

No branches or pull requests
2 participants
@rwinch @jgrandja