Skip to content

Ldap Integration Tests Should Run Independently #5942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Oct 11, 2018 · 3 comments · Fixed by #7231
Closed

Ldap Integration Tests Should Run Independently #5942

jzheaux opened this issue Oct 11, 2018 · 3 comments · Fixed by #7231
Assignees
@jzheaux
Labels
in: ldap An issue in spring-security-ldap in: test An issue in spring-security-test type: enhancement A general enhancement
Milestone
General Backlog

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Oct 11, 2018

Several of the ldap integration tests rely on a parent integration test to orchestrate their execution.

This is no longer necessary, as evidenced by LdapUserDetailsManagerPasswordModifyTests which stands up the appropriate LDAP container on its own.

Having them run independently will make local testing and bug fixes easier. It will also simplify the Gradle script, which currently must specifically identify these parent tests so that their dependent "child" tests don't run on their own.
@jzheaux jzheaux added in: ldap An issue in spring-security-ldap in: test An issue in spring-security-test type: enhancement A general enhancement labels Oct 11, 2018
@jzheaux jzheaux added this to the 5.2.0 milestone Oct 11, 2018
@jzheaux jzheaux mentioned this issue Oct 11, 2018
Merged
@jzheaux jzheaux modified the milestones: 5.2.0, 5.2.x Oct 23, 2018
@jzheaux jzheaux self-assigned this Oct 25, 2018
@jzheaux jzheaux modified the milestones: 5.2.x, General Backlog Oct 26, 2018
@eddumelendez
Copy link
Contributor

Hi @jzheaux, I would like to take this one. one question, should we use the UnboundIdContainer?

@eddumelendez eddumelendez mentioned this issue Aug 7, 2019
Merged
@jzheaux
Copy link
Contributor Author

jzheaux commented Aug 7, 2019

@eddumelendez I think we should keep using the container against which the test was written. However, if we make these tests independent from ApacheDS-specific super-classes, then they could likely be rewritten to test against both containers.

@eddumelendez
Copy link
Contributor

@jzheaux I submitted #7231 and is running against ApacheDS which is the current container

eddumelendez added a commit to eddumelendez/spring-security that referenced this issue Aug 8, 2019
@eddumelendez
Make ldap integration tests independent
7cd3085 
Fixes spring-projectsgh-5942
jzheaux pushed a commit that referenced this issue Aug 8, 2019
@eddumelendez @jzheaux
Make ldap integration tests independent
a171d8b 
Fixes gh-5942
kostya05983 pushed a commit to kostya05983/spring-security that referenced this issue Aug 26, 2019
@eddumelendez @kostya05983
Make ldap integration tests independent
5bd5ac7 
Fixes spring-projectsgh-5942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: ldap An issue in spring-security-ldap in: test An issue in spring-security-test type: enhancement A general enhancement
Projects
None yet
Milestone
General Backlog
Development

Successfully merging a pull request may close this issue.

Make ldap integration tests independent eddumelendez/spring-security
2 participants
@eddumelendez @jzheaux