-
Notifications
You must be signed in to change notification settings - Fork 6k
Update webflux-form sample to use Thymeleaf Built in CSRF Support #6061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd like to take this one 😁 |
Thanks @Daniel69 The issue is all yours! If you need any help, please don't hesitate to reach out to me |
Thank @rwinch, I'll start by reading https://github.com/spring-projects/spring-security/blob/master/CONTRIBUTING.md |
@rwinch I removed the CsrfControllerAdvice and added a dependency to org.thymeleaf.extras:thymeleaf-extras-springsecurity5:3.0.4.RELEASE because 'org.thymeleaf.extras:thymeleaf-extras-springsecurity' alone does not resolve, but two tests fail once I remove the Controller Advice (loginWhenInvalidUsernameThenError and loginAndLogout). |
@Daniel69 Sorry for the delay getting back to you. The problem is that we aren't using Spring Boot 2.1.0.RELEASE yet. I created #6082 which will resolve this. Once it is updated to Boot 2.1.0.RELEASE you should be able to remove the version from |
Thanks again for your patience. Now that #6082 has been resolved, you should be able to rebase off of master and remove the version from thymeleaf-extras-springsecurity5. If you need any help with this, please let me know. |
Remove the CsrfControllerAdvice class and update dependencies to add org.thymeleaf.extras:thymeleaf-extras-springsecurity5 Issue: spring-projectsgh-6061
Remove the CsrfControllerAdvice class and update dependencies to add org.thymeleaf.extras:thymeleaf-extras-springsecurity5 Issue: gh-6061
Remove the CsrfControllerAdvice class and update dependencies to add org.thymeleaf.extras:thymeleaf-extras-springsecurity5 Issue: gh-6061
Remove the CsrfControllerAdvice class and update dependencies to add org.thymeleaf.extras:thymeleaf-extras-springsecurity5 Issue: spring-projectsgh-6061
Summary
Thymeleaf provides automatic integration with Spring Security's CSRF support. We should update the webflux-form sample to demonstrate it.
../../../gradlew check
The text was updated successfully, but these errors were encountered: