-
Notifications
You must be signed in to change notification settings - Fork 6k
Update to Gradle 4.10.2 #6106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@raphaelDL I am not sure I understand this issue. Did you try to update to Gradle 4.10.2 and it failed? I know there are warnings, but that seems distinct from the subject of |
ohhh I see it now, I think I'm getting it wrong here by I'm mixing issues -Update Gradle version My mistake was looking at this as a way to remove all issues when building the project but I failed to recognize that Given the title, you're right... this issue should cover only updating Gradle, and I should open two more to address the rest. If there are not other things to consider when updating Gradle, I'd be happy to take this... |
Thanks. Yes. We'd love to update to a newer version of Gradle and (in separate PRs as you mentioned) remove the deprecated APIs. |
With current version of Gradle 4.10.1 when I run a task with
./gradlew ...
I get these warnings:
> Configure project :spring-security-aspects The Task.deleteAllActions() method has been deprecated. This is scheduled to be removed in Gradle 5.0.
> Configure project :spring-security-samples-javaconfig-x509 Found slf4j-api dependency but no providers were found. Did you mean to add slf4j-simple? See https://www.slf4j.org/codes.html#noProviders .
What if we do the next?
Upgrade Gradle
./gradlew wrapper --gradle-version 4.10.2
Update
buildSrc/src/main/groovy/aspectj/AspectJPlugin.groovy
from
javaCompileTask.deleteAllActions()
to
javaCompileTask.setActions new ArrayList(0)
orjavaCompileTask.setActions Arrays.asList()
/samples/javaconfig/x509/spring-security-samples-javaconfig-x509.gradle
Remove
compile 'org.slf4j:slf4j-api'
The text was updated successfully, but these errors were encountered: